Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Adapter Protocol: Events do not have 'event' key #234

Closed
fwcd opened this issue Aug 17, 2018 · 5 comments
Closed

Debug Adapter Protocol: Events do not have 'event' key #234

fwcd opened this issue Aug 17, 2018 · 5 comments
Milestone

Comments

@fwcd
Copy link
Contributor

fwcd commented Aug 17, 2018

A sample JSON event output from my debug adapter:

{"type":"event","seq":3,"command":"initialized","body":null}

The specification - however - requires an event key, instead of a command key:

interface Event extends ProtocolMessage {
  type: 'event';

  /**
   * Type of event.
   */
  event: string;

  /**
   * Event-specific information.
   */
  body?: any;
}

interface InitializedEvent extends Event {
  event: 'initialized';
}

See https://microsoft.github.io/debug-adapter-protocol/specification#Events_Initialized

Not sure if this is a version inconsistency related to #232

@jonahgraham
Copy link
Contributor

@fwcd fancy a pull request for this one?

@fwcd
Copy link
Contributor Author

fwcd commented Aug 18, 2018

@jonahgraham Sure, I can create one

@fwcd
Copy link
Contributor Author

fwcd commented Aug 18, 2018

@jonahgraham I have squashed and signed my commits, so they should be ready for merge.

jonahgraham pushed a commit that referenced this issue Aug 18, 2018
Signed-off-by: fwcd <fwcdmail@gmail.com>
@jonahgraham
Copy link
Contributor

@fwcd Thanks for the fix!

@spoenemann spoenemann added this to the v0.5.0 milestone Aug 20, 2018
vladdu pushed a commit to vladdu/lsp4j that referenced this issue Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants