Support for NamedPipes

[TylerLeonhardt]

Hi there!

I'm the maintainer of the PowerShell language server, PowerShell Editor Services.

@ant-druha has been working very hard on making a PowerShell extension for Intellij-IDEs. This leverages lsp4j. However, he's run into an issue.

The PowerShell language server uses NamePipes (or UNIX domain sockets) to communicate with the language client - this is so that an extension can leverage a PowerShell Integrated Console that we expose via stdio.

What @ant-druha has noticed is that Java + NamedPipes don't get along well when you treat them as InputStream and OutputStream see here and here.

Concurrent read/write doesn't seem possible this way which is the only way to leverage lsp4j.

so what's the solution?

Sadly, I'm not too familiar with the Java ecosystem so I don't have an answer... but if there is another way to do concurrent reads and writes with NamedPipes, perhaps another constructor could be added to take that in.

Any thoughts?

[spoenemann]

When you use LSP4J with Java sockets, make sure you use the AsynchronousServerSocketChannel, but not the ServerSocketChannel. As you mentioned, the latter does not support concurrent read/write.

[ant-druha]

@spoenemann not sure I understand your suggestion. The request is about non-blocking Named pipes connection support, not about tcp sockets. There are no issues with using tcp sockets for lsp4j transport.

[spoenemann]

I never tried using such named pipes in Java...

[jonahgraham]

Is this still an issue LSP4J needs to solve? The linked issue is fixed in ant-druha/intellij-powershell#6

[apupier]

I guess not. I think it will be safe to close the issue (to clean the backlog)