Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics for mp fault-tolerance Asynchronous annotation #74

Closed
rzgry opened this issue Sep 14, 2020 · 2 comments · Fixed by #168 or #175
Closed

Diagnostics for mp fault-tolerance Asynchronous annotation #74

rzgry opened this issue Sep 14, 2020 · 2 comments · Fixed by #168 or #175
Assignees
Labels
java-files Features supported in Java files validation
Milestone

Comments

@rzgry
Copy link
Member

rzgry commented Sep 14, 2020

https://github.com/eclipse/microprofile-fault-tolerance/blob/master/spec/src/main/asciidoc/asynchronous.asciidoc#asynchronous

Any methods marked with this annotation must return one of:

java.util.concurrent.Future
java.util.concurrent.CompletionStage
Otherwise, org.eclipse.microprofile.faulttolerance.exceptions.FaultToleranceDefinitionException occurs during deployment.

@rzgry rzgry self-assigned this Sep 14, 2020
@kathrynkodama
Copy link
Contributor

I can pick this up

@rzgry rzgry assigned kathrynkodama and unassigned rzgry Sep 16, 2020
@angelozerr angelozerr added the java-files Features supported in Java files label Sep 18, 2020
@angelozerr angelozerr added this to the 0.4.0 milestone Aug 27, 2021
@angelozerr
Copy link

angelozerr commented Sep 7, 2021

I reopen the issue because according to this test https://github.com/eclipse/microprofile-fault-tolerance/blob/e7a1f982b2a0bae837ae99115e8da5e9c67d230b/tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/invalidParameters/AsynchronousClientForValidationClass.java#L30, it seems that @asynchronous annotation can be set on the class (not only on the methods) and all methods are considered as Asynchronous (it's my supposition)

@AlexXuChen could you check that in a real application, implement this new usecase and write a test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment