Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch JAX-RS API dep to jakarta.ws.rs-api #153

Closed
berezovskyi opened this issue Feb 17, 2019 · 13 comments · Fixed by #500
Closed

Switch JAX-RS API dep to jakarta.ws.rs-api #153

berezovskyi opened this issue Feb 17, 2019 · 13 comments · Fixed by #500

Comments

@berezovskyi
Copy link
Member

This is the new dependency name after Java EE was transferred to Eclipse.

@berezovskyi
Copy link
Member Author

ns: jar:file:///tmp/jetty-0.0.0.0-8080-ROOT.war-_-any-10587981168939945327.dir/webapp/WEB-INF/lib/jakarta.ws.rs-api-2.1.5.jar!/javax/ws/rs/sse/SseEventSource.class, jar:file:///tmp/jetty-0.0.0.0-8080-ROOT.war-_-any-10587981168939945327.dir/webapp/WEB-INF/lib/javax.ws.rs-api-2.1.jar!/javax/ws/rs/sse/SseEventSource.class

@berezovskyi berezovskyi transferred this issue from eclipse/lyo.core Aug 21, 2021
@berezovskyi
Copy link
Member Author

We should consider a set of parallel modules in Lyo to support both. Rationale:

  • Need to switch in order to be able to use Tomcat 10 or Jetty 11, they no longer support the old APIs.
  • Eclipse Microprofile introduces a number of specs needed for production and cloud-native use of OSLC servers, we'd like to adopt them. They are baselined on the Jakarta EE (new namespace).

@berezovskyi berezovskyi added this to the 5.1 milestone May 9, 2022
@berezovskyi berezovskyi modified the milestones: 5.1, 5.x May 19, 2022
@berezovskyi berezovskyi modified the milestones: 5.x, 7.x, 7.0 Aug 11, 2023
@danlz
Copy link

danlz commented Jan 11, 2024

I second this, the sooner the better :)

@jhemm2
Copy link
Contributor

jhemm2 commented Mar 13, 2024

+1 for this. This will make lyo usable in springboot 3 projects, using java17 and JakartaEE9

@danlz
Copy link

danlz commented Mar 13, 2024

We are almost at the point of abandoning Lyo and do the stuff ourselves.

@jhemm2
Copy link
Contributor

jhemm2 commented Mar 13, 2024

I am just trying to implement that change and to create a PR, so hopefully it can be integrated early in an upcoming release?

@Jad-el-khoury
Copy link
Contributor

I am just trying to implement that change and to create a PR, so hopefully it can be integrated early in an upcoming release?

Contributions are very welcome. What makes an open source project successful is when users also contribute.
@jhemm2! Feel free to push a PR early, and maybe I can even help out.

@jhemm2
Copy link
Contributor

jhemm2 commented Mar 13, 2024

Lots of changes, unfortunately the editorconfig did not work very well so xml files got some reformatting :/
#500

@Jad-el-khoury
Copy link
Contributor

Great @jhemm2 ! A big change so need to think on how we process this.
Any reason #500 is closed?

@jhemm2
Copy link
Contributor

jhemm2 commented Mar 13, 2024

First time I am trying to to contribute, and I saw some build was failing so I decided to delete the PR and validate the changes again.
Guess I need some support: Is it the right way to fork the repo, do the changes, then to create a PR into master?
Also on my local machine the build was successful, I need to check what is missing

Edit: I'll give it another try, maybe you guys can help me out in case something is wrong: #501

@Jad-el-khoury
Copy link
Contributor

Can you see the results of the actions on https://github.com/eclipse/lyo/actions ? Not sure if you have access..
I can see the maven error, and just want to make sure you can also see it.

When it comes to contribution, doing a PR is very fine.
Please see these guidelines. https://github.com/eclipse/lyo/blob/master/CONTRIBUTING.md

Most importantly, are you an Eclipse Contributor?

@berezovskyi
Copy link
Member Author

@Jad-el-khoury I replied on #500

@danlz
Copy link

danlz commented Jun 25, 2024

What is the plan for releasing the 6.0.0 aka Jakarta version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants