Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the TCK tests CDI 4 compatible #742

Closed
manovotn opened this issue Apr 19, 2022 · 0 comments · Fixed by #743
Closed

Make the TCK tests CDI 4 compatible #742

manovotn opened this issue Apr 19, 2022 · 0 comments · Fixed by #743
Assignees
Labels
area: TCK Issue related to the TCK area
Milestone

Comments

@manovotn
Copy link
Contributor

As you might know, CDI 4 (EE 10) will bring some breaking changes one of which is the change of discovery mode in case of empty beans.xml. The original tracking issue can be seen at jakartaee/cdi#500

The change is that such bean archive will now use annotated discovery mode and CDI container will only pick up beans with bean defining annotations. Previously, all classes were picked up and processes, so this mostly affects classes that had no CDI annotation but were expected to become beans.

This change affects the TCKs in this project.

Note that this can be fixed rather easily and in a compatible manner so that the TCKs will keep working in the current version (CDI 3) as well as with the updated version (CDI 4) with no further changes needed once the migration hits.

I have changes prepared locally and will submit a PR once I have it verified against an impl (using SR impl with updated Weld 5 container).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: TCK Issue related to the TCK area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants