Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submitted tasks are not drained in tests expecting a failure #198

Closed
McFoggy opened this issue Nov 21, 2017 · 0 comments
Closed

submitted tasks are not drained in tests expecting a failure #198

McFoggy opened this issue Nov 21, 2017 · 0 comments
Milestone

Comments

@McFoggy
Copy link
Contributor

McFoggy commented Nov 21, 2017

in bulkhead tests using Utils#loop() and expecting an Exception to be thrown, the submitted Future tasks are not drained at the end of the loop. They are drained only in case of success.

When using in your implementation a single threadpool for asynchronous bulkhead operations this make later tests to start with a threadpool that is possibly already filled making the later test to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants