Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry metrics specification is a little unclear #491

Closed
Ladicek opened this issue Jan 9, 2020 · 0 comments · Fixed by #492
Closed

retry metrics specification is a little unclear #491

Ladicek opened this issue Jan 9, 2020 · 0 comments · Fixed by #492
Assignees
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Jan 9, 2020

Some of the retry metrics are specified in a little unclear way:

ft.<name>.retry.callsSucceededNotRetried.total: The number of times the method was called and succeeded without retrying
ft.<name>.retry.callsSucceededRetried.total: The number of times the method was called and succeeded after retrying at least once
ft.<name>.retry.callsFailed.total: The number of times the method was called and ultimately failed after retrying

In all cases, the text seems to assume that there is no other fault tolerance strategy applied. For example, if there's a fallback strategy, then the method will not "ultimately fail" even though all retry attempts fail.

We should provide more clear specification text here, one that doesn't assume absence of other FT strategies and is only worded in terms of the retry operation and not the ultimate result of the method call.

@Ladicek Ladicek added this to the 2.1 milestone Jan 9, 2020
@Ladicek Ladicek self-assigned this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant