Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with MicroProfile Telemetry Metrics #622

Closed
2 tasks
Emily-Jiang opened this issue Feb 21, 2024 · 6 comments · Fixed by #623
Closed
2 tasks

Work with MicroProfile Telemetry Metrics #622

Emily-Jiang opened this issue Feb 21, 2024 · 6 comments · Fixed by #623
Assignees
Milestone

Comments

@Emily-Jiang
Copy link
Member

Description

As a:

  • API User (application developer)
  • Specification Implementer

...I need to be able to:

get OpenTelemetry metrics

...which enables me to:

get unified metrics

@Emily-Jiang Emily-Jiang added this to the 4.1 milestone Feb 21, 2024
@benjamin-confino
Copy link
Contributor

benjamin-confino commented Mar 22, 2024

I did an experiment in OpenLiberty and was able to modify our integration layer between mpFaultTolerence and mpMetrics to use telemetry metrics with minimal changes. I think we can resolve this issue without changing the fault tolerance code.


Tasks that must be acomplished:

  • Add a section to the fault tolerence specifications covering FT and telemetry integration.
  • Add a package to the TCK to test FT and telemetry integration.

Discussion points

  • Do we want to add or modify the metrics Fault Tolerence records?
  • What happens if both MP Telemetry and MP Metrics are enabled for the first time?

@benjamin-confino
Copy link
Contributor

benjamin-confino commented Apr 26, 2024

#623 Resolves this tasks that must be accomplished. There is still the discussion points.

@Azquelt
Copy link
Member

Azquelt commented May 3, 2024

Do we need/want a new config option to allow the export of metrics to telemetry to be disabled? (like https://download.eclipse.org/microprofile/microprofile-fault-tolerance-4.0.2/microprofile-fault-tolerance-spec-4.0.2.html#_configuring_metrics_integration)

@benjamin-confino
Copy link
Contributor

I think if that option was useful for MP Metrics it will be useful for MP Telemetry. For simplicity I would suggest we use the same property for both, and update the spec to say it covers both.

@Azquelt
Copy link
Member

Azquelt commented Jun 27, 2024

Is this issue complete?

@Azquelt
Copy link
Member

Azquelt commented Aug 7, 2024

The work here is complete, #623 updated the spec and added TCKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants