Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the semantics of context propagation are clear #7

Closed
mmusgrov opened this issue Jun 18, 2018 · 4 comments
Closed

Ensure the semantics of context propagation are clear #7

mmusgrov opened this issue Jun 18, 2018 · 4 comments

Comments

@mmusgrov
Copy link
Contributor

mmusgrov commented Jun 18, 2018

If you have a microservice A that wants to participate in an LRA and calls microservice B (which does not have specific LRA behaviour) and this calls microservice C (which does have specific LRA behaviour), then B should not need to be annotated with @lra. The spec should be clear that is the defined behaviour.

@mmusgrov
Copy link
Contributor Author

PR was merged

@rdebusscher
Copy link
Member

Reopened.

The always propagate Context Header is counter intuitive and does not allow to call an endpoint which doesn't have the Context header (when one is present)

@rdebusscher rdebusscher reopened this Aug 2, 2019
@rdebusscher
Copy link
Member

rdebusscher commented Aug 2, 2019

The proposal is to define a configuration parameter to activate such propagation under all circumstances.

Note, the propagation of the LRA context is ALWAYS perform within an LRA context (JAX-RS method is annotated with @lra except for @LRA.Type.NOT_SUPPORTED as this type means that you do not have an LRA context active)

@rdebusscher
Copy link
Member

No Consensus in trying to make this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants