Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support a hierarchy of metrics? #29

Open
mikecroft opened this issue Aug 22, 2017 · 3 comments
Open

Should we support a hierarchy of metrics? #29

mikecroft opened this issue Aug 22, 2017 · 3 comments
Labels

Comments

@mikecroft
Copy link
Member

Currently (for 1.0), Metrics exposes a flat list of available metrics.

There is a possibility of supporting a hierarchy instead (as discussed in #26). Is this a good idea and for what use case might we want to implement it?

@mikecroft mikecroft added this to the 1.1 milestone Aug 22, 2017
@keilw
Copy link

keilw commented Sep 18, 2017

That sounds a bit similar to Spring Boot (which I used as inspiration for a recent project, but we could do without hierarchical metrics there)
Of course there are plenty of caveats, especially if the hierarchy should allow to cummulate values, you must not mix the unit

@kwsutter
Copy link
Contributor

Can we clarify what hierarchy is being proposed? I read through #26 and Heiko's recent post to the Google group. In Heiko's post he mentioned allowing more than one app per server. Is that a common topology? Given the cloud environment and kubernetes control of app servers, it would seem that a more common topology would be to limit one app per server.

@keilw
Copy link

keilw commented Oct 30, 2017

#26 talks a lot about hierarchies in the sense of rest endpoints or "actuators". If there's just one /metrics endpoint per server, then a hierarchy on the rest level could only be added via filters like /metrics/SOMETHING as mentioned. Maybe we should distinguish between hierarchy and aggregate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants