New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update base metric names and types #375

Closed

donbourne opened this issue May 2, 2019 · 0 comments · Fixed by #376

Assignees

Milestone

Member

donbourne commented May 2, 2019

Given counters now only count monotonically, need to change the following from Counters to Gauges:

thread.count
thread.daemon.count
classloader.currentLoadedClass.count
thread.max.count (this one is a bit subjective, but aiming to reserve Counters for accumulating counts, not for maximums)

Given metrics that count up over time and represent a cumulative total should end with ".total", need to change:

gc.count -> gc.total
classloader.totalLoadedClass.count -> classloader.loadedClasses.total
classloader.totalUnloadedClass.count -> classloader.unloadedClasses.total

To keep classloader metric names consistent with the above changes, also need to change

classloader.currentLoadedClass.count -> classloader.loadedClasses.count

donbourne self-assigned this

donbourne mentioned this issue

Changes to base metric names and types #376

Merged

jmartisk added this to the 2.0 milestone

pilhuhn closed this as completed in #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment