Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to enable/disable quantiles for Timers/Histograms #673

Closed
donbourne opened this issue Jul 6, 2022 · 1 comment
Closed

add ability to enable/disable quantiles for Timers/Histograms #673

donbourne opened this issue Jul 6, 2022 · 1 comment
Assignees
Milestone

Comments

@donbourne
Copy link
Member

donbourne commented Jul 6, 2022

This should include the ability to enable/disable by configuration
This may also include the ability to enable/disable programmatically

@donbourne donbourne added this to the 5.0 milestone Jul 6, 2022
@donbourne donbourne removed this from the 5.0 milestone Aug 9, 2022
@donbourne donbourne added this to the 5.1 milestone Oct 7, 2022
@donbourne donbourne changed the title add ability to enable/disable quantiles when registering Timers/Histograms add ability to enable/disable quantiles for Timers/Histograms Oct 11, 2022
@Channyboy Channyboy self-assigned this Jun 20, 2023
@Channyboy
Copy link
Contributor

Channyboy commented Jun 28, 2023

Related to #675
There will be no explicit MP configuration for enabling and disabling quantiles.
Quantiles will be enabled by default.

Quantiles can be disabled through configuration of the quantile values by setting a value.

i.e.

mp.metrics.distribution.percentiles=	                            // means no percentiles
mp.metrics.distribution.percentiles=*=	                            // means no percentiles for all metrics
mp.metrics.distribution.percentiles=*=;a=0.5                    // means all off, except metric a 
mp.metrics.distribution.percentiles=some.metric=;a=0.5  // means some.metric disabled quantiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants