Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify: Which annotations can be used on private methods? #769

Closed
breakponchito opened this issue Feb 27, 2023 · 1 comment · Fixed by #770
Closed

Clarify: Which annotations can be used on private methods? #769

breakponchito opened this issue Feb 27, 2023 · 1 comment · Fixed by #770
Assignees
Milestone

Comments

@breakponchito
Copy link

When working to pass the TCK I saw that the following test were added to annotate private methods with @Gauge annotation:

that means that the following documentation is not correct because here is still indicating that non private methods should be used with this annotation:

Can someone clarify which annotations can be used with private methods?

@breakponchito breakponchito changed the title Clarify: Which annotations can be used in private methods? Clarify: Which annotations can be used on private methods? Feb 27, 2023
@Channyboy
Copy link
Contributor

Hello, sorry for the confusion. The specification does explicitly references "non-private" methods. However, similarly doesn't explicitly rule out private methods which open it up for interpretation.

But yes, this does cause a conflict as this wouldn't be the obvious interpretation of the wording in the specification.
We'll bring this up in the next MP Metrics call and discuss it and will either remove that TCK test in a 5.0.1 release or amend the specification.

@Channyboy Channyboy self-assigned this Apr 10, 2023
@Channyboy Channyboy added this to the 5.0.1 milestone Apr 11, 2023
This was referenced Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants