Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Scopes class should be deprecated (similar to ServerVariables) #328

Closed
EricWittmann opened this issue Jan 4, 2019 · 2 comments
Closed

Comments

@EricWittmann
Copy link
Contributor

The Scopes class seems to be a leftover from OpenAPI 2.0. The 3.0 specification does not have a Scopes object.

OpenAPI 2.0: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#scopesObject
OpenAPI 3.0: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#oauth-flow-object

In 3.0 scopes is a simple Map property of the OAuth Flow object. As a result it is not extensible and should be modeled as a simple map in MP+OAI.

@arthurdm
Copy link
Member

arthurdm commented Jan 4, 2019

I agree - and there's a good example inside SecurityRequirement (following this part of the spec) on how to store a scope without needing a new class.

@Rachelwrq Rachelwrq mentioned this issue Apr 12, 2019
@jmini
Copy link
Contributor

jmini commented May 17, 2019

This is fixed with PRs:

Feel free to reopen if you disagree.

@jmini jmini closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants