Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit org.eclipse.microprofile.rest.client.ext.AsyncInvocationInterceptor #202

Open
rmannibucau opened this issue Jun 2, 2019 · 2 comments
Labels

Comments

@rmannibucau
Copy link

Hello everyone,

I just discovered org.eclipse.microprofile.rest.client.ext.AsyncInvocationInterceptor and have to admit I don't understand at all that API.

There are two main remarks about it:

  1. if you intend to make libraries/user code enable to use that multi-phase API then all but last step should be able to return a context so API would rather be:

    public interface AsyncInvocationInterceptor {
    A prepareContext();
    A applyContext();
    void removeContext();
    }

otherwise the user/library must relies on some custom thread factory passed to the executor of the client which leads to my second point

  1. This API is already there in JAX-RS through the executor passed to the Client, it enables any user to wrap client Runnable and therefore gets exactly the same kind of hook so IMHO this API just brings noise to plain JAX-RS but no feature.

Any option to deprecate it to drop it next year?

Romain

@jamezp
Copy link
Contributor

jamezp commented Feb 26, 2024

Is this still an issue?

@rmannibucau
Copy link
Author

Im dont have any MP app anymore so guess there is no point fixing it from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants