Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Xtext 2.13 and cleanup @szarnekow's changes #79

Open
mmews-n4 opened this issue Jul 17, 2017 · 3 comments
Open

Update to Xtext 2.13 and cleanup @szarnekow's changes #79

mmews-n4 opened this issue Jul 17, 2017 · 3 comments

Comments

@mmews-n4
Copy link
Contributor

When fixing #39, @szarnekow introduced changes that can be reverted after updating to XText 2.13. To do this, search for Xtext 2.13 / 2.13 or refer to pull request's changes.

@yoosiba
Copy link
Contributor

yoosiba commented Mar 29, 2018

should be tackled after #637 (#370) is merged.

@yoosiba
Copy link
Contributor

yoosiba commented May 25, 2018

Note in many places in code there is TODO remove with Xtext 2.13 that should be searched for when working on this task. See:
https://github.com/eclipse/n4js/pull/138/files#diff-9123c7830f32f5a7edf66df8e7a7f0d5R25
https://github.com/eclipse/n4js/pull/65/files#diff-98014d08661739d97fbc0c75eb0c7f64R358

@szarnekow
Copy link
Contributor

All the changes marked with expected to be part of the framework in 2.13 didn't make it into 2.13. Everything was part of 2.14 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants