Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure_linux_arm.mk should integrate with openJDK configure #1956

Open
JamesKingdon opened this issue Nov 4, 2017 · 3 comments
Open

configure_linux_arm.mk should integrate with openJDK configure #1956

JamesKingdon opened this issue Nov 4, 2017 · 3 comments

Comments

@JamesKingdon
Copy link
Contributor

The settings for the cross compiler tool chain and global includes in configure_linux_arm.mk (and compiler flags in rules.linux.mk) need to be settable from the openJDK configure settings as we currently have the same information redundantly scattered across four or five files.

@mgaudet
Copy link

mgaudet commented Nov 6, 2017

I suspect this issue would be better served at https://github.com/eclipse/openj9, even if the ultimate code change happens in OMR...

@JamesKingdon
Copy link
Contributor Author

@mgaudet I also opened eclipse-openj9/openj9#518 to cover openj9 specifics.

@JamesKingdon
Copy link
Contributor Author

I've addressed this issue via #2057

That fix might be considered a temporary step as instead of integrating with the openJDK configure it gets the necessary information from environment variables provided by the Docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants