Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused temps from x86 CodeGenerator #5423

Closed
0xdaryl opened this issue Jul 22, 2020 · 5 comments
Closed

Remove unused temps from x86 CodeGenerator #5423

0xdaryl opened this issue Jul 22, 2020 · 5 comments

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Jul 22, 2020

The following fields in compiler/x/codegen/OMRCodeGenerator.hpp are not used in OMR nor any downstream project and can be removed:

  TR::SymbolReference             *_wordConversionTemp;
  TR::SymbolReference             *_doubleWordConversionTemp;
  TR::SymbolReference             *_currentTimeMillisTemp;
@kevHaag
Copy link

kevHaag commented Jul 22, 2020

I am on it.(not anymore)

@jamesgua
Copy link
Contributor

@0xdaryl my mistake: create PR in my forked repo so link it with this issue. Pls help me with proper work flow. Thx!

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Jul 27, 2020

@jamesgua : I suggest you read through this to understand the git workflow in OMR -> https://github.com/eclipse/omr/blob/master/doc/GitCrashCourse.md

@arshbeerSingh
Copy link

Can you please assign this issue to me?

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Oct 26, 2020

@arshbeerSingh : thanks for your offer to help. Please feel free to contribute a pull request.

I do recommend you first read through the Contributors Guide, and if you're not familiar with git and the workflow for OMR to read through our git Crash Course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants