Add JVMTI VirtualThread Mount and Unmount Events #16501

dipak-bagadiya · 2023-01-02T07:12:28Z

JVMTI VirtualThreadMount and VirtualThreadUnMount events are part of
the JVMTI Extension API which is not covered by the JVMTI
documentation.

The following JVMTI extension events are implemented:
-VirtualThreadmount: Trigger/Hook the Virtual thread mount event
-VirtualThreadUnmount: Trigger/Hook the Virtual thread unmount event

Related: #16167

Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com

dipak-bagadiya · 2023-01-02T07:20:36Z

@babsingh requesting you to please review it.

babsingh · 2023-01-03T13:39:41Z

The copyright dates in all files will change to , 2023. E.g.

 * Copyright (c) 1991, 2023 IBM Corp. and others

babsingh · 2023-01-03T13:45:09Z

eclipsefdn/eca failure: Commits need to be signed off using the Github ID associated with the Eclipse ECN.
There are three commits. There should only be one commit. Something went wrong during rebase. A simple fix is to recreate the branch and cherry-pick the single commit.

babsingh · 2023-01-03T14:50:39Z

From @dipak-bagadiya

After executing the test case:

make test TEST="jtreg:test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest" JTREG="JAVA_OPTIONS=--enable-preview -Dvm.continuations=true;VERBOSE=all"

The below error is seen:

in jvmtiEventManagement event_type: 48
error in JVMTI SetEventNotificationMode: 102

Potential fix

We have to modify jvmtiSetEventNotificationMode to handle JVMTI extension events. @dipak-bagadiya Suggest a solution by looking at its implementation/code.

runtime/oti/jvmtiInternal.h

babsingh · 2023-01-03T15:07:39Z

jvmtiSetEventNotificationMode: Suggest a solution by looking at its implementation/code.

VIRTUAL_THREAD_[MOUNT|UNMOUNT] events require the can_support_virtual_threads. So, these events need to be included in this switch case:

openj9/runtime/jvmti/jvmtiEventManagement.c

Lines 159 to 164 in a2475ea

    
           #if JAVA_SPEC_VERSION >= 19 
        
           				case JVMTI_EVENT_VIRTUAL_THREAD_START: 
        
           				case JVMTI_EVENT_VIRTUAL_THREAD_END: 
        
           					ENSURE_CAPABILITY(env, can_support_virtual_threads); 
        
           					break; 
        
           #endif /* JAVA_SPEC_VERSION >= 19 */

An error is thrown based on the J9JVMTI_LOWEST_EVENT and J9JVMTI_HIGHEST_EVENT. This range needs to be updated to include all JVMTI extension events. See the implementation of setEventNotificationMode for the error-handling code.

openj9/runtime/jvmti/jvmtiEventManagement.c

Line 214 in a2475ea

rc = setEventNotificationMode(j9env, currentThread, mode, event_type, event_thread, J9JVMTI_LOWEST_EVENT, J9JVMTI_HIGHEST_EVENT);

babsingh

The title needs to change: Add JVMTI VirtualThread Mount and Unmount Events
In the PR, there should only be one commit just with the Mount and Unmount changes.
The second commit is from JVMTI Extension Functions: GetVirtualThread and GetCarrierThread #16518. It should not be part of this PR. Locally, it can be cherry-picked for testing.
The commit should have a body with more details about the code changes.
See my local branch: https://github.com/babsingh/openj9/commits/jvmti_extension_funcs_all. The first commit only has the GetVirtualThread and GetCarrierThread changes, and the second commit has the changes for the Mount and Unmount events.
The new changes should be enabled for JDK19+. See the usage of #if JAVA_SPEC_VERSION >= 19 in JVMTI Extension Functions: GetVirtualThread and GetCarrierThread #16518. This mostly applies to code. Macros such as #define COM_IBM_GET_VIRTUAL_THREAD ... do not need to be ifdef'ed; they can stay defined all the time.

Note: This is a first review pass. I will review it again after the current feedback is addressed.

debugtools/DDR_VM/data/superset-constants.dat

runtime/jvmti/jvmtiHook.c

runtime/oti/j9consts.h

runtime/jvmti/jvmtiHook.c

babsingh

Second review pass.

runtime/include/ibmjvmti.h

runtime/nls/j9ti/jvmti.nls

runtime/jvmti/jvmtiExtensionMechanism.c

runtime/jvmti/jvmtiHook.c

runtime/jvmti/jvmtiExtensionMechanism.c

runtime/nls/j9ti/jvmti.nls

runtime/oti/j9vm.hdf

babsingh · 2023-01-23T04:04:06Z

jenkins test sanity zlinux jdk19

babsingh · 2023-01-23T04:04:39Z

jenkins compile win jdk8,jdk19

babsingh · 2023-01-23T14:30:03Z

This PR LGTM. @gacholio Can you please review this PR for any VM access issues?

runtime/oti/j9vm.hdf

runtime/jvmti/jvmtiEventManagement.c

runtime/oti/jvmtiInternal.h

gacholio · 2023-01-25T18:07:00Z

Can you please review this PR for any VM access issues?

I see no VM access problems (the JVMTI event code is designed to be tolerant of whatever state VM access is in).

Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

babsingh · 2023-02-01T14:36:05Z

Updated tests across JDK19+ extension repos to use extension_event_index:

JDK-next: Use GetExtensionEvents to derive extension event numbers ibmruntimes/openj9-openjdk-jdk#545
JDK20: Use GetExtensionEvents to derive extension event numbers ibmruntimes/openj9-openjdk-jdk20#13
JDK19: Use GetExtensionEvents to derive extension event numbers ibmruntimes/openj9-openjdk-jdk19#65

For this PR's commit, reverted the numbering for extension events in the top commit of https://github.com/babsingh/openj9/commits/jvmti_extension_funcs. See the changes to runtime/oti/jvmtiInternal.h.

@dipak-bagadiya Can you please apply the above runtime/oti/jvmtiInternal.h changes to this PR, and also verify the new test changes?

gacholio · 2023-02-01T18:11:01Z

Is currentThread->threadObject the virtual thread when the mount/unmount hooks are fired?

Assuming the answer is yes, please document this in the hook declarations.

dipak-bagadiya · 2023-02-01T18:45:56Z

@babsingh added the changes of "runtime/oti/jvmtiInternal.h" to this PR and verified the test with the updated test module.

dipak-bagadiya · 2023-02-02T11:47:29Z

currentThread->threadObject
@gacholio
Should I add or document the currentThread->threadObject in j9vm.hdf?

gacholio · 2023-02-02T12:36:26Z

Should I add or document the currentThread->threadObject in j9vm.hdf?

Please do.

JVMTI VirtualThreadMount and VirtualThreadUnMount events are part of the JVMTI Extension API which is not covered by the JVMTI documentation. The following JVMTI extension events are implemented: -VirtualThreadmount: Trigger/Hook the Virtual thread mount event -VirtualThreadUnmount: Trigger/Hook the Virtual thread unmount event Fixes: eclipse-openj9#16167 Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com

dipak-bagadiya · 2023-02-02T16:16:23Z

currentThread->threadObject

@gacholio added currentThread->threadObject at the point of hook declarations in j9vm.hdf

gacholio · 2023-02-02T16:20:32Z

jenkins test sanity zlinux jdk19

gacholio · 2023-02-02T16:20:44Z

jenkins compile win jdk8

Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

The below tests successfully pass with the implementation of VirtualThread[M|Unm]ount and Get[Virtual|Carrier]Thread: - BreakpointInYieldTest.java - NullAsCurrentThreadTest.java - VThreadUnsupportedTest.java - GetStackTraceSuspendedStressTest.java - RawMonitorTest.java Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16518 Signed-off-by: Dipak Bagadiya <dipak.bagadiya@ibm.com>

babsingh reviewed Jan 3, 2023

View reviewed changes

runtime/oti/jvmtiInternal.h Show resolved Hide resolved

pshipton added the comp:vm label Jan 3, 2023

dipak-bagadiya force-pushed the jvmti-MountUnmout-fix branch 3 times, most recently from e90196f to 48d7330 Compare January 3, 2023 18:22

babsingh added comp:jvmti jdk20 labels Jan 4, 2023

babsingh mentioned this pull request Jan 6, 2023

JVMTI Extension Functions: GetVirtualThread and GetCarrierThread #16518

Merged

babsingh requested changes Jan 18, 2023

View reviewed changes

dipak-bagadiya force-pushed the jvmti-MountUnmout-fix branch 4 times, most recently from ba822d5 to 94969e6 Compare January 19, 2023 15:24

dipak-bagadiya marked this pull request as ready for review January 19, 2023 15:25

dipak-bagadiya changed the title ~~added JVMTI VirtualThread Mount and UnMount Events.~~ Add JVMTI VirtualThread Mount and Unmount Events Jan 19, 2023

babsingh requested changes Jan 20, 2023

View reviewed changes

dipak-bagadiya force-pushed the jvmti-MountUnmout-fix branch 2 times, most recently from 8577f12 to d3c96a5 Compare January 20, 2023 18:03

gacholio reviewed Jan 24, 2023

View reviewed changes

runtime/oti/j9vm.hdf Outdated Show resolved Hide resolved

gacholio reviewed Jan 24, 2023

View reviewed changes

runtime/jvmti/jvmtiEventManagement.c Show resolved Hide resolved

gacholio reviewed Jan 25, 2023

View reviewed changes

runtime/oti/jvmtiInternal.h Outdated Show resolved Hide resolved

babsingh mentioned this pull request Feb 1, 2023

Use GetExtensionEvents to derive extension event numbers ibmruntimes/openj9-openjdk-jdk19#65

Merged

babsingh mentioned this pull request Feb 1, 2023

Use GetExtensionEvents to derive extension event numbers ibmruntimes/openj9-openjdk-jdk20#13

Merged

babsingh mentioned this pull request Feb 1, 2023

Use GetExtensionEvents to derive extension event numbers ibmruntimes/openj9-openjdk-jdk#545

Merged

dipak-bagadiya force-pushed the jvmti-MountUnmout-fix branch 2 times, most recently from f969307 to 4c250a4 Compare February 1, 2023 18:10

dipak-bagadiya mentioned this pull request Feb 2, 2023

Re-enable JVMTI tests adoptium/aqa-tests#4300

Merged

dipak-bagadiya force-pushed the jvmti-MountUnmout-fix branch from 4c250a4 to 326b9e1 Compare February 2, 2023 16:14

gacholio approved these changes Feb 2, 2023

View reviewed changes

gacholio merged commit 114c390 into eclipse-openj9:master Feb 2, 2023

babsingh mentioned this pull request Apr 28, 2023

[JDK19] JVMTI VirtualThread[Mount|UnMount] Events #16167

Closed

mikezhang1234567890 mentioned this pull request May 5, 2023

Add JVMTI events for CRIU checkpoint and restore #17252

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JVMTI VirtualThread Mount and Unmount Events #16501

Add JVMTI VirtualThread Mount and Unmount Events #16501

dipak-bagadiya commented Jan 2, 2023 •

edited

dipak-bagadiya commented Jan 2, 2023

babsingh commented Jan 3, 2023 •

edited

babsingh commented Jan 3, 2023

babsingh commented Jan 3, 2023

babsingh commented Jan 3, 2023 •

edited

babsingh left a comment •

edited

babsingh left a comment

babsingh commented Jan 23, 2023

babsingh commented Jan 23, 2023

babsingh commented Jan 23, 2023

gacholio commented Jan 25, 2023

babsingh commented Feb 1, 2023

gacholio commented Feb 1, 2023 •

edited

dipak-bagadiya commented Feb 1, 2023

dipak-bagadiya commented Feb 2, 2023

gacholio commented Feb 2, 2023

dipak-bagadiya commented Feb 2, 2023

gacholio commented Feb 2, 2023

gacholio commented Feb 2, 2023

Add JVMTI VirtualThread Mount and Unmount Events #16501

Add JVMTI VirtualThread Mount and Unmount Events #16501

Conversation

dipak-bagadiya commented Jan 2, 2023 • edited

dipak-bagadiya commented Jan 2, 2023

babsingh commented Jan 3, 2023 • edited

babsingh commented Jan 3, 2023

babsingh commented Jan 3, 2023

From @dipak-bagadiya

Potential fix

babsingh commented Jan 3, 2023 • edited

babsingh left a comment • edited

Choose a reason for hiding this comment

babsingh left a comment

Choose a reason for hiding this comment

babsingh commented Jan 23, 2023

babsingh commented Jan 23, 2023

babsingh commented Jan 23, 2023

gacholio commented Jan 25, 2023

babsingh commented Feb 1, 2023

gacholio commented Feb 1, 2023 • edited

dipak-bagadiya commented Feb 1, 2023

dipak-bagadiya commented Feb 2, 2023

gacholio commented Feb 2, 2023

dipak-bagadiya commented Feb 2, 2023

gacholio commented Feb 2, 2023

gacholio commented Feb 2, 2023

dipak-bagadiya commented Jan 2, 2023 •

edited

babsingh commented Jan 3, 2023 •

edited

babsingh commented Jan 3, 2023 •

edited

babsingh left a comment •

edited

gacholio commented Feb 1, 2023 •

edited