Convert PullRequests to pipeline of jobs #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
9 times, most recently
from
0810ca5
to
ec43af0
Compare
TODO
|
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
from
9d82a3a
to
be154ae
Compare
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
11 times, most recently
from
79cb4c6
to
db96f7c
Compare
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
7 times, most recently
from
d3c46cc
to
899c2aa
Compare
pshipton
reviewed
May 6, 2019
buildenv/jenkins/README.md
Outdated
| - `Jenkins test sanity.functional zlinux jdk8,jdk11` | ||
| - Request an extended functional and system build on pLinux for a single version | ||
| - `Jenkins test extended.functional,extended.system plinux jdk8` | ||
| - Request a sanity build on z,p Linux for multiple versions | ||
| - `Jenkins test sanity zlinux,plinux jdk8,jdk9` |
There was a problem hiding this comment.
How about removing jdk9 here since it is obsolete.
pshipton
reviewed
May 6, 2019
buildenv/jenkins/README.md
Outdated
| @@ -80,6 +105,8 @@ You can also request a Pull Request build from the Eclipse OpenJ9 repository - [ | |||
| - Ex. If you have a dependent change and only want one platform, depends comes last | |||
| - `Jenkins test sanity zlinux jdk8 depends eclipse/omr#123` | |||
|
|
|||
| ###### Note: When specifying a dependent change in an OpenJDK extensions repo, you can only build the SDK version that matches the repo where the dependent change lives. Eg. You cannot build JDK8 with a PR in openj9-openjdk-jdk9. | |||
There was a problem hiding this comment.
Also here, remove the ref to the obsolete jdk9
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
from
ab2ed6a
to
d06c581
Compare
|
Not sure "Fixes #2728" is appropriate if the conversion to Pipeline builds doesn't occur when this is merged. |
pshipton
reviewed
May 6, 2019
| @@ -84,8 +84,6 @@ build_discarder: | |||
| OMR: 20 | |||
| OpenJDK: 20 | |||
| Personal: 50 | |||
| # tmp PRs | |||
| pullRequest: 50 | |||
There was a problem hiding this comment.
Is it appropriate to remove this before converting PRs to pipeline builds?
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
from
d06c581
to
c1f5093
Compare
pshipton
reviewed
May 6, 2019
| error("Unknown PLATFORM short:'${SHORT}'\nExpected one of:${SHORT_NAMES}") | ||
| } | ||
| } | ||
| echo "PLATFORMS:'${PLATFORMS}'" |
There was a problem hiding this comment.
Added a comment to comment block at the beginning of setup_pull_request()
pshipton
reviewed
May 6, 2019
| * 3+ - jdk versions | ||
| */ | ||
| def PARSED_COMMENT = params.ghprbCommentBody.toLowerCase().tokenize(' ') | ||
| if (PARSED_COMMENT[0] != 'jenkins') { |
There was a problem hiding this comment.
We should use a different trigger than 'jenkins' at least temporarily, so we can run pipeline PR builds concurrently with the old style PR builds for testing purposes. One suggestion is 'pipeline'
There was a problem hiding this comment.
Removed this check since it is technically redundant. The trigger regex in the jenkins job verifies PARSED_COMMENT[0]. We can change it to pipeline on the new jobs until we are ready to change over completely.
- PRs currently run in separate, stand-alone jobs and this is not maintenance friendly. - There are many benefits to switching to the common workflow of "pipeline of jobs" used by all other builds. - This PR adds support for PR builds to use Pipeline-Build-Test-All as a top-level job. - This also adds support in pipeline-functions to accomodate various functionality needed by PRs. - Update README to reflect changes. - Auto-Cancel Test jobs when new ones are launched from the same PR - Only allow restarts for UNSTABLE builds. Issue eclipse-openj9#2728 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
convert_pr_to_pipeline
branch
from
c1f5093
to
209a40a
Compare
pshipton
approved these changes
May 7, 2019
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
May 7, 2019
- GIT_BRANCH is passed from Github for PR builds. This param was overiding the default value of 'master' in PR builds which causes PRs to fail to find the ref. Related eclipse-openj9#2836 eclipse-openj9#4443 eclipse-openj9#4783 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
May 7, 2019
- Current check uses ghprbGhRepository which is now used for non-pr builds - Change to pull id as this param is only passed for old and new style pr builds Related eclipse-openj9#2836 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
LinHu2016
pushed a commit
to LinHu2016/openj9
that referenced
this pull request
May 7, 2019
- GIT_BRANCH is passed from Github for PR builds. This param was overiding the default value of 'master' in PR builds which causes PRs to fail to find the ref. Related eclipse-openj9#2836 eclipse-openj9#4443 eclipse-openj9#4783 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
LinHu2016
pushed a commit
to LinHu2016/openj9
that referenced
this pull request
May 7, 2019
- Current check uses ghprbGhRepository which is now used for non-pr builds - Change to pull id as this param is only passed for old and new style pr builds Related eclipse-openj9#2836 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
May 15, 2019
- xlinux - xlinuxXL - osx - win - win32 - aix - plinux - zlinux - Also change the values to be lists in order to support multiple values [skip ci] Related eclipse-openj9#2836 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Jun 11, 2019
- We no longer run our own testing so this code is no longer needed. - Remove PullRequest pipelines as they are no longer in use. - Combine 'build' and 'pullRequest' variable setup cases as they are identical. - Also remove temp reverse spec map used prior to eclipse-openj9#2836. Related eclipse-openj9#1450 Depends eclipse-openj9#2728 eclipse-openj9#2638 eclipse-openj9#2467 eclipse-openj9#2272 eclipse-openj9#2836 eclipse-openj9#4443 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and this is not maintenance friendly.
workflow of "pipeline of jobs" used by all other builds.
Pipeline-Build-Test-All as a top-level job.
various functionality needed by PRs.
what a build belongs to (Nightly, OMR, PR#123 etc)
Issue #2728
[skip ci]
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com