Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 1: JEP 360 Sealed Classes #10120

Merged
merged 5 commits into from Jul 14, 2020
Merged

Part 1: JEP 360 Sealed Classes #10120

merged 5 commits into from Jul 14, 2020

Conversation

theresa-m
Copy link
Contributor

first part of: #9626

  • class verification/write to ROM class PermittedSubclasses attribute
  • Class.isSealed and Class.permittedSubclasses implementation
  • tests for new JCL methods

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

@theresa-m theresa-m mentioned this pull request Jul 8, 2020
Closed
@pshipton pshipton added this to the Release 0.22 (Java 15) milestone Jul 8, 2020
@pshipton pshipton added the jdk15 label Jul 8, 2020
@JasonFengJ9 JasonFengJ9 mentioned this pull request Jul 10, 2020
Closed
@gacholio
Copy link
Contributor

I've not forgotten this, but I have to prepare myself for a 30-file review.

gacholio
gacholio reviewed Jul 13, 2020
View reviewed changes
runtime/oti/util_api.h Outdated Show resolved Hide resolved
gacholio
gacholio reviewed Jul 13, 2020
View reviewed changes
runtime/util/optinfo.c Outdated Show resolved Hide resolved
@gacholio
Copy link
Contributor

I did not review the test code.

@theresa-m
Write PermittedSubclasses attribute to ROM class
0a333e6 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
New JCL Class.isSealed method and tests
774b7c5 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
New JCL Class.permittedSubclasses method and tests
a1f964b 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Update Subclasses from Subtypes
0e498c8 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@gacholio
Copy link
Contributor

jenkins test sanity,extended zlinux jdk15

@gacholio
Copy link
Contributor

jenkins compile win jdk8

@theresa-m
First review changes
11d6161 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@gacholio
Copy link
Contributor

jenkins test sanity,extended win jdk15

@gacholio gacholio merged commit 01cb796 into eclipse-openj9:master Jul 14, 2020
@theresa-m theresa-m deleted the sealedclasses branch July 20, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gacholio gacholio gacholio left review comments

@DanHeidinga DanHeidinga Awaiting requested review from DanHeidinga

Assignees
No one assigned
Labels
comp:test comp:vm jdk15
Projects
None yet
Milestone
Release 0.22 (Java 15)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theresa-m @gacholio @pshipton