Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate AOT Relocation Records #10451

Merged
merged 12 commits into from Aug 25, 2020

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Aug 25, 2020

Remove the duplicated code that writes the
TR_ValidateClassFromITableIndexCP relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Aug 25, 2020

@mstoodle very likely the 4th last one of these PRs 🎉

Remove the duplicated code that writes the
TR_ValidateDeclaringClassFromFieldOrStatic relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateConcreteSubClassFromClass relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateClassChain relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateMethodFromClass relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Add a parent class for the various validate method from CP validation
records.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateStaticMethodFromCP relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateSpecialMethodFromCP relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateVirtualMethodFromCP relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateVirtualMethodFromOffset relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateInterfaceMethodFromCP relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Remove the duplicated code that writes the
TR_ValidateMethodFromClassAndSig relocation header
information, and consolidate it in one canonical location.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@mstoodle
Copy link
Contributor

jenkins test sanity all jdk8,jdk11

@mstoodle
Copy link
Contributor

I reviewed the commits and they all look ok to me. Once the tests finish and assuming pass, I'll merge.

@mstoodle mstoodle merged commit b57ed79 into eclipse-openj9:master Aug 25, 2020
@mstoodle
Copy link
Contributor

Great progress, @dsouzai !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants