Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the AdoptOpenJDK Tests repository to Jenkins pipelines #4523

Merged
merged 1 commit into from Feb 5, 2019

Conversation

vsebe
Copy link
Contributor

@vsebe vsebe commented Jan 30, 2019

Add the AdoptOpenJDK Tests repository and branch to the variables file.
Pass to the downstream jobs the URL and the branch of the AdoptOpenJDK
Testing repository.

[ci skip]

Signed-off-by: Violeta Sebe vsebe@ca.ibm.com

@vsebe
Copy link
Contributor Author

vsebe commented Jan 30, 2019

@jdekonin @llxia please review, thx

Copy link
Contributor

@jdekonin jdekonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the event there is a requirement to use an alternate repo and branch for adopt test material, I think this looks good.

@vsebe vsebe force-pushed the jenkins.adopt branch 3 times, most recently from e0f9b6d to 190b0ee Compare February 4, 2019 20:27
@vsebe
Copy link
Contributor Author

vsebe commented Feb 4, 2019

@llxia ready for review, thank you!

Add the AdoptOpenJDK Tests repository and branch to the variables file.
Pass to the downstream jobs the URL and the branch of the AdoptOpenJDK
Testing repository.

[ci skip]

Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
@vsebe
Copy link
Contributor Author

vsebe commented Feb 5, 2019

@llxia
Copy link
Contributor

llxia commented Feb 5, 2019

Tested in personal build. PR builds cannot verify Jenkinsfile changes.

@llxia llxia merged commit c9f790e into eclipse-openj9:master Feb 5, 2019
@vsebe vsebe deleted the jenkins.adopt branch April 23, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants