Remove enter/exit tracing methods #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
force-pushed
the
3585-methodTracingReduction-m
branch
from
a582b10
to
0034657
Compare
a7ehuo
changed the title
In practice we never enable methodEnterTracing without methodExitTracing.These two methods are replaced by isMethodTracingEnabled(). Issue: eclipse-openj9#3585 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
3585-methodTracingReduction-m
branch
from
0034657
to
cc8c401
Compare
|
@mpirvu FYI |
|
@cathyzhyi FYI - is there anything in any of the new JVMTI capabilities that may want us to distinguish these two cases (enter vs exit tracing)? |
|
LGTM. The jvmti hooks need to distinguish method enter and exit but they use different APIs |
|
@mpirvu Please help review. Thank you. |
|
jenkins test sanity all jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice we never enable methodEnterTracing without
methodExitTracing.These two methods are replaced by
isMethodTracingEnabled().
Issue: #3585
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com