Fix temp slot bug in valueType generator #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a reference type, the valueType generator does not account for doubles when placing the new ref type in a temp slot. In addition the max locals specified for the method does not take into account the temp slot required for the new ref type. This PR fixes both those issues. Signed-off-by: tajila <atobia@ca.ibm.com>
|
@llxia Please review this change |
|
will forgo PR build as it will not test Valhalla tests atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix temp slot bug in valueType generator
When creating a reference type, the valueType generator does not
account for doubles when placing the new ref type in a temp slot.
In addition the max locals specified for the method does not take
into account the temp slot required for the new ref type. This PR
fixes both those issues.
Signed-off-by: tajila atobia@ca.ibm.com