Replace the incorrect assert with verbose log #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsouzai Could you help review and launch Jenkins? Thanks. |
dsouzai
requested changes
Mar 20, 2019
`validateAOTHeader()` is supposed to fail when the current lockword hash value does not match the one in the shared cache. The assert in `incompatibleCache()` and `generateError()` are too harsh. Replace it with the verbose log. Fixes eclipse-openj9#5149 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
incompatibleCache
branch
from
e100f0f
to
b664b8b
Compare
dsouzai
approved these changes
Mar 20, 2019
|
jenkins test sanity xlinux jdk8,jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateAOTHeader()is supposed to fail when the current lockwordhash value does not match the one in the shared cache.
The assert in
incompatibleCache()andgenerateError()are too harsh. Replace it with the verbose log.
Fixes #5149
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com