Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the z/OS 64-bit default OS stack size to 1MB #5204

Merged
merged 1 commit into from Mar 22, 2019
Merged

Set the z/OS 64-bit default OS stack size to 1MB #5204

merged 1 commit into from Mar 22, 2019

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Mar 21, 2019 •
edited

@pshipton pshipton changed the title Set the z/OS 64-bit default OS stack size to 1MB WIP Set the z/OS 64-bit default OS stack size to 1MB Mar 21, 2019
DanHeidinga
DanHeidinga reviewed Mar 22, 2019
View reviewed changes
runtime/oti/j9cfg_builder.h Outdated Show resolved Hide resolved
runtime/oti/j9cfg_builder.h Show resolved Hide resolved
@pshipton
Copy link
Member Author

I asked @PhilWakelin to take a look at the build:

ran a standalone Java process that spawned a thread and dumped this address space

The LE SANC was as follows:

    SANC:  00000050_22400058                                                    
  +000000  EYE_CATCHER:SANC  VERSION:0001      LENGTH:0100                      
  +000008  SEGMENT_SIZE:00000000 00000081      ACTIVE_STACK:00000050_86D00000    
  +000018  BOS:00000050_8EDFFFE0   INIT_SIZE:00000000 00000001                  
  +000028  INCR_SIZE:00000000 00000001   USER_STACK:00000050_86D00000            
  +000038  USER_BOS:00000050_8EDFFFE0    USER_FLOOR:00000050_8ED00000            
  +000048  RESERVE_STACK:00000050_22500000     SDCB:00000000_00000000            
  +000060  PTDATA:00000050_22400000      OCB_INCRSZ:00000000 00000000            
  +000070  CURR_ALLOC:00000000 00000000        FLAGS1:00000000                  
  +00007C  FLAGS2:00000000   USER_ORIGIN:00000050 22500000                      


This shows that the thread stack (USER_FLOOR - USER_BOS)  is 1M as expected, and  SEGMENT_SIZE is 129M which is consistent with the default LE THREADSTACK64 of 128M+1M

@pshipton pshipton changed the title WIP Set the z/OS 64-bit default OS stack size to 1MB Set the z/OS 64-bit default OS stack size to 1MB Mar 22, 2019
@pshipton
Set the z/OS 64-bit default OS stack size to 1MB
87919b7 
[ci skip]

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@DanHeidinga DanHeidinga self-assigned this Mar 22, 2019
@DanHeidinga
Copy link
Member

Jenkins compile zlinux jdk8

@DanHeidinga DanHeidinga merged commit 2b55c0b into eclipse-openj9:master Mar 22, 2019
@pshipton pshipton deleted the zosstack branch May 31, 2019 18:13
@pshipton pshipton mentioned this pull request Jun 19, 2019
Closed
@pshipton pshipton mentioned this pull request Oct 1, 2019
Merged
pshipton added a commit to pshipton/openj9 that referenced this pull request Oct 10, 2019
@pshipton
Set the z/OS 64-bit minimum OS stack size to 1MB
921c442 
Even when the user requests a smaller size, use 1MB.

Issue eclipse-openj9#6150
Related to eclipse-openj9#5204

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanHeidinga DanHeidinga DanHeidinga approved these changes

Assignees

@DanHeidinga DanHeidinga

Labels
comp:vm depends:doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use 1MB as native thread stack size minimum on 64-bit z/OS
2 participants
@pshipton @DanHeidinga