Implement jstack in 0.14 #5336
Merged
Implement jstack in 0.14 #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create general tooling to convert mxbeans to properties and vice versa. Implement main class to implement the command line utility. Overwrite jdk.jcmd module definition to add new required modules. Add service provider to allows java.base to access classes from foreign modules. Update module exports and jpp configuration. Reorganize tools directory to ease filtering source directories. Add tests for jstack. Needs coordinated changes in extensions repositories. Fixes eclipse-openj9#4858 [ci skip] Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
Merged
pshipton
approved these changes
Apr 3, 2019
pdbain-ibm
added a commit
to pdbain-ibm/openj9
that referenced
this pull request
Jun 21, 2019
In the target VM use only classes available in the java.base module. Rework original implementation of jstack: "Implement jstack in 0.14" eclipse-openj9#5336 - Create the result string at the target instead of the attacher - Delete unnecessary classes and packages - Delete unit tests for deleted classes and other dead test code - Minor stylistic cleanup while I have the files open [ci skip] Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create general tooling to convert mxbeans to properties and vice versa.
Implement main class to implement the command line utility. Overwrite jdk.jcmd
module definition to add new required modules.
Add service provider to allows java.base to access classes from foreign
modules. Update module exports and jpp configuration. Reorganize
tools directory to ease filtering source directories. Add tests for jstack.
Needs coordinated changes in extensions repositories.
Fixes #4858
Port of #5150
[ci skip]
Signed-off-by: Peter Bain peter_bain@ca.ibm.com