Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: Implement AheadOfTimeCompile::processRelocations() #6264

Merged
merged 1 commit into from Oct 9, 2019
Merged

AArch64: Implement AheadOfTimeCompile::processRelocations() #6264

merged 1 commit into from Oct 9, 2019

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jun 25, 2019

This commit implements processRelocations() in J9AheadOfTimeCompile.cpp
for AArch64.

Signed-off-by: knn-k konno@jp.ibm.com

@0xdaryl
Copy link
Contributor

0xdaryl commented Jul 3, 2019

@dsouzai , would you mind reviewing this one please?

@dsouzai dsouzai self-assigned this Jul 4, 2019
dsouzai
dsouzai requested changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as per previous comments

@knn-k
Copy link
Contributor Author

knn-k commented Jul 4, 2019

Thank you @dsouzai. I am working on other PRs now, and I will revisit this one later.

@knn-k
Copy link
Contributor Author

knn-k commented Oct 9, 2019

Fixed the type cast in *(uint32_t *)relocationDataCursor = reloBufferSize; to (uintptrj_t *).

@knn-k
AArch64: Implement AheadOfTimeCompile::processRelocations()
3d60393 
This commit implements processRelocations() in J9AheadOfTimeCompile.cpp
for AArch64.

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Oct 9, 2019 •
edited

Finished updating files.
Putting all the related PRs together, now AOT has started working on AArch64 with my local build.

@dsouzai
Copy link
Contributor

dsouzai commented Oct 9, 2019

Jenkins compile alinux64xl jdk11

@dsouzai dsouzai merged commit 59f8c6c into eclipse-openj9:master Oct 9, 2019
@knn-k knn-k deleted the aarch64codegen12 branch October 9, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai dsouzai approved these changes

Assignees

@dsouzai dsouzai

Labels
arch:aarch64 comp:jit:aot comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knn-k @0xdaryl @dsouzai