Fix Insertion of allocationFence #6628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlenBadel
force-pushed
the
bfix
branch
2 times, most recently
from
184a3db
to
279ebce
Compare
When compiling methods that include calls to constructors that initialize private fields in some cases an allocationfence was not inserted after the call. Previously, isFinalFieldFromSuperClasses was incorrectly comparing the instance size of the superclass and the size of the field offset. This was due to padding that could occur, causing the size of the superclass instance to be greater than it's actual size within the derived class. isFinalFieldFromSuperClasses is removed in exchange for newly created jitGetDeclaringClassOfROMField that returns the J9Class which declares the given ROM field. Signed-off-by: Alen Badel <Alen.Badel@ibm.com>
|
Ready to review. |
gacholio
reviewed
Jul 30, 2019
zl-wang
approved these changes
Jul 30, 2019
gacholio
approved these changes
Jul 30, 2019
liqunl
approved these changes
Jul 30, 2019
|
Jenkins test sanity plinux jdk8 jdk11 jdk13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling methods that include calls to constructors that initialize private fields in some cases an allocationfence was not inserted after the call.
Previously, isFinalFieldFromSuperClasses was incorrectly comparing the instance size of the superclass and the size of the field offset.
This was due to padding that could occur, causing the size of the superclass instance to be greater than it's actual size within the derived class.
isFinalFieldFromSuperClasses is removed in exchange for newly created jitGetDeclaringClassOfROMField that returns the J9Class which declares the given ROM field.
Signed-off-by: Alen Badel Alen.Badel@ibm.com