Create resolved method with valid vtable offset #6993

liqunl · 2019-09-06T13:41:11Z

Create resolved method with valid vtable offset for invokeinterface call
site that is resolved to a virtual method.

Closes: #6940

Signed-off-by: Liqun Liu liqunl@ca.ibm.com

liqunl · 2019-09-09T14:28:28Z

@DanHeidinga May I ask for your reivew? @fjeremic Could you help review the JIT part?

runtime/oti/j9protos.h

liqunl · 2019-09-13T17:35:01Z

@DanHeidinga ping?

DanHeidinga

I've been tracing the use of vtableOffset back through the JIT code as it feels a bit like an attractive nuisance in that it will only be filled in sometimes and the API isn't clear on when / why it would be filled in.

runtime/jit_vm/cthelpers.cpp

runtime/oti/j9protos.h

runtime/compiler/env/j9method.cpp

Create resolved method with valid vtable offset for invokeinterface call site that is resolved to a virtual method. Closes: eclipse-openj9#6940 Signed-off-by: Liqun Liu <liqunl@ca.ibm.com>

pshipton · 2019-09-16T15:32:19Z

Note there is a copyright check failure https://ci.eclipse.org/openj9/job/PullRequest-CopyrightCheck-OpenJ9/18783/

liqunl · 2019-09-16T16:01:53Z

@pshipton The failed files are not my change, something's wrong with the copyright checking job?

pshipton · 2019-09-16T17:19:42Z

ok, could be. I didn't look at the failures, I just saw it was associated with this PR.

pshipton · 2019-09-16T17:24:01Z

The copyright check job isn't being posted back the PR right now, some problems could have slipped in.

liqunl · 2019-09-17T13:46:10Z

@fjeremic Could you start the jenkins builds?

fjeremic · 2019-09-17T13:49:46Z

I think they've been very flaky today. But we can give it a shot.

Jenkins test sanity all jdk11

pshipton · 2019-09-17T14:00:15Z

The PR build started but has problems https://ci.eclipse.org/openj9/view/all/job/PullRequest-OpenJ9/1232/

AdamBrousseau · 2019-09-17T14:28:39Z

Jenkins test sanity all jdk11

AdamBrousseau · 2019-09-17T14:29:05Z

https://ci.eclipse.org/openj9/view/Pull%20Requests/job/PullRequest-OpenJ9/1233/

fjeremic · 2019-09-18T21:55:50Z

All tests have passed in the failing build, however the build is marked as failed due to infrastructure issues at the end. I'm comfortable merging this change given this.

13:38:51  TOTAL: 230   EXECUTED: 155   PASSED: 155   FAILED: 0   DISABLED: 4   SKIPPED: 71
13:38:51  ALL TESTS PASSED
13:38:51  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
13:38:51  
13:38:51  _sanity.functional done
13:38:51  make: Leaving directory '/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/openjdk-tests'
[Pipeline] sh
13:38:54  ++ uname
13:38:54  + '[' Linux = AIX ']'
13:38:54  ++ uname
13:38:54  + '[' Linux = SunOS ']'
13:38:54  + MAKE=make
13:38:54  + make -f ./openjdk-tests/TestConfig/testEnv.mk testEnvTeardown
13:38:54  make: Nothing to be done for 'testEnvTeardown'.
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Post)
[Pipeline] timestamps
[Pipeline] {
[Pipeline] step
13:38:55  TAP Reports Processing: START
13:38:55  Looking for TAP results report in workspace using pattern: **/*.tap
13:38:55  Saving reports...
13:38:56  Processing '/var/jenkins_home/jobs/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/builds/108/tap-master-files/openjdk-tests/TestConfig/test_output_15687349513077/TestTargetResult.tap'
13:38:56  Parsing TAP test result [/var/jenkins_home/jobs/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/builds/108/tap-master-files/openjdk-tests/TestConfig/test_output_15687349513077/TestTargetResult.tap].
13:38:56  TAP Reports Processing: FINISH
[Pipeline] junit
13:38:56  Recording test results
13:38:57  None of the test reports contained any result
[Pipeline] getArtifactoryServer
[Pipeline] newBuildInfo
[Pipeline] artifactoryUpload
expected to call org.jfrog.hudson.pipeline.common.types.ArtifactoryServer.upload but wound up catching artifactoryUpload; see: https://jenkins.io/redirect/pipeline-cps-method-mismatches/
13:37:51  [consumer_0] Deploying artifact: https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Test/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/108/SHA.txt
13:37:56  Error occurred for request PUT /artifactory/ci-eclipse-openj9/Test/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/108/SHA.txt;build.parentNumber=623;build.parentName=Pipeline_Build_Test_JDK11_x86-64_linux_xl;build.timestamp=1568733548791;build.name=Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal;build.number=108 HTTP/1.1: 140-211-168-230-openstack.osuosl.org: Temporary failure in name resolution.
13:37:56  Attempting retry #1
13:37:56  Error occurred for request PUT /artifactory/ci-eclipse-openj9/Test/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/108/SHA.txt;build.parentNumber=623;build.parentName=Pipeline_Build_Test_JDK11_x86-64_linux_xl;build.timestamp=1568733548791;build.name=Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal;build.number=108 HTTP/1.1: 140-211-168-230-openstack.osuosl.org.
13:37:56  Attempting retry #2
13:37:56  Error occurred for request PUT /artifactory/ci-eclipse-openj9/Test/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/108/SHA.txt;build.parentNumber=623;build.parentName=Pipeline_Build_Test_JDK11_x86-64_linux_xl;build.timestamp=1568733548791;build.name=Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal;build.number=108 HTTP/1.1: 140-211-168-230-openstack.osuosl.org.
13:37:56  Attempting retry #3
13:37:56  Error occurred for request PUT /artifactory/ci-eclipse-openj9/Test/Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal/108/SHA.txt;build.parentNumber=623;build.parentName=Pipeline_Build_Test_JDK11_x86-64_linux_xl;build.timestamp=1568733548791;build.name=Test_openjdk11_j9_sanity.functional_x86-64_linux_xl_Personal;build.number=108 HTTP/1.1: 140-211-168-230-openstack.osuosl.org.
13:37:57  [consumer_0] An exception occurred during execution:
13:37:57  java.lang.RuntimeException: java.net.UnknownHostException: 140-211-168-230-openstack.osuosl.org
13:37:57  	at org.jfrog.build.extractor.clientConfiguration.util.spec.SpecDeploymentConsumer.consumerRun(SpecDeploymentConsumer.java:44)
13:37:57  	at org.jfrog.build.extractor.producerConsumer.ConsumerRunnableBase.run(ConsumerRunnableBase.java:11)
13:37:57  	at java.lang.Thread.run(Thread.java:748)
13:37:57  Caused by: java.net.UnknownHostException: 140-211-168-230-openstack.osuosl.org
13:37:57  	at java.net.InetAddress.getAllByName0(InetAddress.java:1281)
13:37:57  	at java.net.InetAddress.getAllByName(InetAddress.java:1193)
13:37:57  	at java.net.InetAddress.getAllByName(InetAddress.java:1127)
13:37:57  	at org.apache.http.impl.conn.SystemDefaultDnsResolver.resolve(SystemDefaultDnsResolver.java:45)
13:37:57  	at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:112)
13:37:57  	at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:373)
13:37:57  	at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
13:37:57  	at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
13:37:57  	at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
13:37:57  	at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
13:37:57  	at org.apache.http.impl.execchain.ServiceUnavailableRetryExec.execute(ServiceUnavailableRetryExec.java:85)
13:37:57  	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
13:37:57  	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
13:37:57  	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
13:37:57  	at org.jfrog.build.client.PreemptiveHttpClient.execute(PreemptiveHttpClient.java:122)
13:37:57  	at org.jfrog.build.client.ArtifactoryHttpClient.execute(ArtifactoryHttpClient.java:221)
13:37:57  	at org.jfrog.build.client.ArtifactoryHttpClient.upload(ArtifactoryHttpClient.java:217)
13:37:57  	at org.jfrog.build.extractor.clientConfiguration.client.ArtifactoryBuildInfoClient.uploadFile(ArtifactoryBuildInfoClient.java:689)
13:37:57  	at org.jfrog.build.extractor.clientConfiguration.client.ArtifactoryBuildInfoClient.doDeployArtifact(ArtifactoryBuildInfoClient.java:376)
13:37:57  	at org.jfrog.build.extractor.clientConfiguration.client.ArtifactoryBuildInfoClient.deployArtifact(ArtifactoryBuildInfoClient.java:364)
13:37:57  	at org.jfrog.build.extractor.clientConfiguration.util.spec.SpecDeploymentConsumer.consumerRun(SpecDeploymentConsumer.java:39)
13:37:57  	... 2 more
13:37:57  
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // stage
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is disabled by the job configuration...
[WS-CLEANUP] done
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // stage
[Pipeline] End of Pipeline
java.lang.Exception: Error occurred during operation, please refer to logs for more information.
	at org.jfrog.build.extractor.producerConsumer.ProducerConsumerExecutor.start(ProducerConsumerExecutor.java:85)
	at org.jfrog.build.extractor.clientConfiguration.util.spec.SpecsHelper.uploadArtifactsBySpec(SpecsHelper.java:113)
	at org.jfrog.hudson.generic.GenericArtifactsDeployer$FilesDeployerCallable.invoke(GenericArtifactsDeployer.java:165)
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to cent6-x64-6
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
		at hudson.remoting.Channel.call(Channel.java:957)
		at hudson.FilePath.act(FilePath.java:1070)
		at hudson.FilePath.act(FilePath.java:1059)
		at org.jfrog.hudson.pipeline.common.executors.GenericUploadExecutor.execute(GenericUploadExecutor.java:55)
		at org.jfrog.hudson.pipeline.scripted.steps.UploadStep$Execution.run(UploadStep.java:72)
		at org.jfrog.hudson.pipeline.scripted.steps.UploadStep$Execution.run(UploadStep.java:52)
		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)
		at hudson.security.ACL.impersonate(ACL.java:290)
		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)
		at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
		at java.util.concurrent.FutureTask.run(Unknown Source)
		at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
		at java.lang.Thread.run(Unknown Source)
Caused: java.lang.RuntimeException: Failed uploading artifacts by spec
	at org.jfrog.hudson.generic.GenericArtifactsDeployer$FilesDeployerCallable.invoke(GenericArtifactsDeployer.java:169)
	at org.jfrog.hudson.generic.GenericArtifactsDeployer$FilesDeployerCallable.invoke(GenericArtifactsDeployer.java:107)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3050)
	at hudson.remoting.UserRequest.perform(UserRequest.java:212)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:369)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Finished: FAILURE

This commit mirrors the jitGetImproperInterfaceMethodFromCP API changes found in eclipse-openj9#6993 to JITClient code. Signed-off-by: Harry Yu <harryyu1994@gmail.com>

liqunl force-pushed the 6940 branch 2 times, most recently from 03ff0d6 to c2ee5e0 Compare September 6, 2019 17:43

fjeremic reviewed Sep 9, 2019

View reviewed changes

runtime/oti/j9protos.h Outdated Show resolved Hide resolved

fjeremic added the comp:jit label Sep 9, 2019

liqunl force-pushed the 6940 branch from c2ee5e0 to 0000105 Compare September 13, 2019 17:30

fjeremic approved these changes Sep 13, 2019

View reviewed changes

DanHeidinga reviewed Sep 13, 2019

View reviewed changes

runtime/jit_vm/cthelpers.cpp Outdated Show resolved Hide resolved

runtime/oti/j9protos.h Outdated Show resolved Hide resolved

runtime/compiler/env/j9method.cpp Show resolved Hide resolved

Create resolved method with valid vtable offset

a59ba25

Create resolved method with valid vtable offset for invokeinterface call site that is resolved to a virtual method. Closes: eclipse-openj9#6940 Signed-off-by: Liqun Liu <liqunl@ca.ibm.com>

liqunl force-pushed the 6940 branch from 0000105 to a59ba25 Compare September 16, 2019 14:51

DanHeidinga approved these changes Sep 16, 2019

View reviewed changes

fjeremic self-assigned this Sep 17, 2019

fjeremic merged commit b0e9913 into eclipse-openj9:master Sep 18, 2019

mpirvu mentioned this pull request Oct 12, 2019

Port TR_J9JITServerSharedCache from jitaas to master #7438

Merged

harryyu1994 mentioned this pull request Oct 15, 2019

Add JITServer SharedCache support #7461

Merged

liqunl deleted the 6940 branch November 20, 2019 16:54

JamesKingdon mentioned this pull request Dec 2, 2019

Segmentation error while jiting WrappedString.apply from Scala 2.10.7 #6940

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create resolved method with valid vtable offset #6993

Create resolved method with valid vtable offset #6993

liqunl commented Sep 6, 2019

liqunl commented Sep 9, 2019

liqunl commented Sep 13, 2019

DanHeidinga left a comment

pshipton commented Sep 16, 2019

liqunl commented Sep 16, 2019

pshipton commented Sep 16, 2019

pshipton commented Sep 16, 2019

liqunl commented Sep 17, 2019

fjeremic commented Sep 17, 2019

pshipton commented Sep 17, 2019

AdamBrousseau commented Sep 17, 2019

AdamBrousseau commented Sep 17, 2019

fjeremic commented Sep 18, 2019 •

edited

Loading

Create resolved method with valid vtable offset #6993

Create resolved method with valid vtable offset #6993

Conversation

liqunl commented Sep 6, 2019

liqunl commented Sep 9, 2019

liqunl commented Sep 13, 2019

DanHeidinga left a comment

Choose a reason for hiding this comment

pshipton commented Sep 16, 2019

liqunl commented Sep 16, 2019

pshipton commented Sep 16, 2019

pshipton commented Sep 16, 2019

liqunl commented Sep 17, 2019

fjeremic commented Sep 17, 2019

pshipton commented Sep 17, 2019

AdamBrousseau commented Sep 17, 2019

AdamBrousseau commented Sep 17, 2019

fjeremic commented Sep 18, 2019 • edited Loading

fjeremic commented Sep 18, 2019 •

edited

Loading