Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Varargs.invokeWithArguments to process excess paramenter #7163

Merged
merged 1 commit into from Oct 8, 2019

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS fengxue-IS commented Sep 19, 2019

  • Store wrapped argument array in a new Object array instead of
    trim and reuse existing argument array
  • Fixes possible ArrayStoreException when the argument array
    passed in is not of Object[]

Fixes: #7009

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

- Store wrapped argument array in a new Object array instead of
	trim and reuse existing argument array
- Fixes possible ArrayStoreException when the argument array
	passed in is not of Object[]

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS fengxue-IS changed the title WIP: Fix Varargs.invokeWithArguments to process excess paramenter Fix Varargs.invokeWithArguments to process excess paramenter Sep 20, 2019
@fengxue-IS
Copy link
Contributor Author

@DanHeidinga can I get a review please

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using System.arraycopy but the number of args is generally going to be small enough that this is likely as efficient

@DanHeidinga
Copy link
Member

Jenkins test sanity win jdk11

@DanHeidinga DanHeidinga self-assigned this Oct 3, 2019
@DanHeidinga DanHeidinga merged commit cd07261 into eclipse-openj9:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTReg Test Failure: java/lang/invoke/LoopCombinatorTest.java
3 participants