Reduced the size of installation files for cuda 9.0 #7280
Conversation
|
Hey @AdamBrousseau! The build and run command work. Thanks for reviewing it! |
|
Hi @keithc-ca! I got this message when building the image from the docker file. |
Hi! I think we know the answer. I did not put the authorized_keys file and the known_hosts file next to the dockerfile. Thanks! |
|
I'm confused why we're making this change. I thought once more testing was added, the full install would be required. Which would also mean adding Cuda to the other Dockerfiles. |
|
You need to follow the instructions at https://github.com/eclipse/openj9/blob/master/buildenv/jenkins/docker-slaves/x86/centos6.9/Dockerfile#L20 |
We need a clear understanding of the purpose of the docker images we seek to create. If it's just used for building the VM, then this is sufficient, if we want an image that can be used for testing a VM then more will be needed (not the least of which is actual GPU hardware). |
These have always been for build and/or test in the farm as well as for dev use. However, the likelihood of running them on a host with a card is slim imo. Which leads me to believe we would only ever install the full kit on a machine with the hardware to back it up. If this is true then this change makes sense to me now. |
|
Note, there is a Cuda(7) install in the cent7 ppcle image which will need this change as well and the change from #7254. I'm not sure if we should also have one in the ub16 390 image. |
CUDA is not supported on s390. |
|
jenkins build docker x86 centos6.9 |
| RUN mkdir -p ${CUDA_HOME}/nvvm | ||
| COPY --from=cuda-dev ${CUDA_HOME}/include ${CUDA_HOME}/include | ||
| COPY --from=cuda-dev ${CUDA_HOME}/nvvm/include ${CUDA_HOME}/nvvm/include |
There was a problem hiding this comment.
I found out the hard way that references such as these depend upon the environment where docker build runs. To be sure the paths are as expected, they should be hard-coded.
There was a problem hiding this comment.
Hi Keith. Thanks for your advice! I will make the change.
[skip ci] Signed-off-by: Jenny Chen <Jenny.Chen@ibm.com>
JennyChenyj
force-pushed
the
reduceCuda9Installation
branch
from
94be3ea
to
0970659
Compare
|
Hi @AdamBrousseau! The changes have been made. Thanks! |
|
jenkins build docker x86 centos6.9 |
| @@ -171,8 +173,8 @@ RUN cd /usr/src \ | |||
| && rm -rf /usr/src/git-2.5.3 | |||
|
|
|||
| # Install ant version 1.10.5. | |||
| RUN wget https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.5-bin.zip \ | |||
| && unzip apache-ant-1.10.5-bin.zip -d /opt \ | |||
| COPY apache-ant-1.10.5-bin.zip . | |||
There was a problem hiding this comment.
Why this change? apache-ant-1.10.5-bin.zip isn't (and shouldn't be) in the openj9 repo.
There was a problem hiding this comment.
The original link for downloading ant expires. Sorry, I am not sure why we use this version. @AdamBrousseau
There was a problem hiding this comment.
The original link expired. We updated it in e22aa46#diff-98f2a595424a7af76747ea2c636f6d19. The COPY was put in temporarily because @JennyChenyj's laptop wasn't resolving the url. This can be removed now.
There was a problem hiding this comment.
It was just removed. Sorry. I forgot we made this change to test the dockerfile. Thanks for explaining it! @AdamBrousseau
[skip ci] Signed-off-by: Jenny Chen <Jenny.Chen@ibm.com>
JennyChenyj
force-pushed
the
reduceCuda9Installation
branch
from
0970659
to
63e393a
Compare
|
jenkins build docker x86 centos6.9 |
2 similar comments
|
jenkins build docker x86 centos6.9 |
|
jenkins build docker x86 centos6.9 |
|
Good Afternoon! The change has made. Please let me know if there is any other change. @pshipton |
|
@AdamBrousseau are you good with these changes? |
|
Just waiting on a compile build to verify the container works as expected. Will post back once it is complete. |
There was a problem hiding this comment.
Please relaunch this build after the merge
https://ci.eclipse.org/openj9/view/Build/job/Build-Jenkins-Agent-Container/90/
[skip ci]
Signed-off-by: Jenny Chen Jenny.Chen@ibm.com