Fix to conservatively stash OSR argument info #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stashing OSR argument info, _couldOSRAtNextBC had been used to tell whether OSR can happen at a certain point. For post transition OSR, when walking an potential OSR point ilgen will set _couldOSRAtNextBC to indicate OSR could happen at next bytecode. However, this doesn't work if the next bytecode is at the start of another block because bytecode iterator can pick up a different block to process. Fix to conservatively assumes OSR can happen at any block start when stashing OSR argument info. Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
|
Jenkins test sanity all jdk8,jdk11 |
1 similar comment
|
Jenkins test sanity all jdk8,jdk11 |
|
Jenkins test sanity plinux jdk8 |
|
plinux jdk8 failure looks unrelated - rerunning to verify. |
|
Looks good |
andrewcraik
approved these changes
Oct 23, 2019
andrewcraik
added
the
backport:candidate
pshipton
removed
the
backport:candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stashing OSR argument info, _couldOSRAtNextBC had been used
to tell whether OSR can happen at a certain point. For post transition
OSR, when walking an potential OSR point ilgen will set
_couldOSRAtNextBC to indicate OSR could happen
at next bytecode. However, this doesn't work if the next bytecode is at
the start of another block because bytecode iterator can pick up a
different block to process. Fix to conservatively assumes OSR can
happen at any block start when stashing OSR argument info.
Signed-off-by: Yi Zhang yizhang@ca.ibm.com