Merge JITServer PR7533 refactor inROMClass #7544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
force-pushed
the
mergeRefactorInROMClass
branch
4 times, most recently
from
1e42788
to
3496125
Compare
PR eclipse-openj9#7533 removed the duplicated definition of inROMClass() from TR_ResolvedJ9JITServerMethod and ClientSessionData::ClassInfo. Define it as isAddressInROMClass() in JITServerHelpers so that ClassEnv could call this API as well. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
mergeRefactorInROMClass
branch
from
3496125
to
ce6784c
Compare
a7ehuo
changed the title
|
@mpirvu Ready for review. Thanks. |
|
Jenkins test sanity all jdk8,jdk11 |
|
Tests have passed, hence merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7533 removed the duplicated definition of
inROMClass()from
TR_ResolvedJ9JITServerMethodandClientSessionData::ClassInfo. Define it asisAddressInROMClass()inJITServerHelpersso that
ClassEnvcould call this API as well.Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com