Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JITServer init bug #7599

Merged
merged 2 commits into from Oct 28, 2019
Merged

Conversation

harryyu1994
Copy link
Contributor

@harryyu1994 harryyu1994 commented Oct 25, 2019

  • Move "jitHookVMInitialized()" to be called only in JITServer::SERVER mode
  • Replace J9_CLASS_FROM_CP with getClassFromCP API

Signed-off-by: Harry Yu harryyu1994@gmail.com

"jitHookVMInitialized()" should only be called in JITServer::SERVER mode

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994
Copy link
Contributor Author

@mpirvu This one is ready for review.

@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Oct 26, 2019
@mpirvu mpirvu added this to In progress in JIT as a Service via automation Oct 26, 2019
@mpirvu mpirvu self-assigned this Oct 26, 2019
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Oct 26, 2019

Jenkins test sanity all jdk8

The two essentially do the same thing but "getClassFromCP" contains JITServer support. When on JITServer, "getClassFromCP" gets the class data remotely from JITClient.

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994
Copy link
Contributor Author

I added another commit. There are no more differences between jitaas and master branch except 1. makefile-related changes 2. dhruv's new Power changes 3. spaces.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Oct 26, 2019

Jenkins test sanity all jdk8,jdk11

@mpirvu
Copy link
Contributor

mpirvu commented Oct 26, 2019

On AIX there is a failure: jsigjnitest_0

==============================================
Running test jsigjnitest_0 ...
===============================================
jsigjnitest_0 Start Time: Sat Oct 26 01:08:04 2019 Epoch Time (ms): 1572070084656
variation: NoOptions
JVM_OPTIONS: -Xcompressedrefs 
Usage: jvmlibpath[-java options]

failed to open </usr/java8_64/jre/lib/ppc64//libjvm.so> - reason: <	0509-022 Cannot load module /usr/java8_64/jre/lib/ppc64//libjvm.so.
	0509-026 System error: A file or directory in the path name does not exist.>
Attempting to open /home/u0020236/workspace/Test_openjdk8_j9_sanity.functional_ppc64_aix_Personal/openjdkbinary/j2sdk-image/jre/bin/../lib/ppc64/j9vm/libjvm.so
About to invoke JNI_CreateJavaVM with 2 option(s).
Starting test.
Primary handler set.
Secondary handler set.
Raising signal.
Test passed. Both signal handlers invoked.
Internal Error: Failed to initialize redirector - exiting

jsigjnitest_0_FAILED

This doesn't seem to be caused by this PR. I'll start again.

@mpirvu
Copy link
Contributor

mpirvu commented Oct 26, 2019

Jenkins test sanity aix jdk11

@mpirvu
Copy link
Contributor

mpirvu commented Oct 28, 2019

AIX test failure does not look to be related to this PR, hence merging

@mpirvu mpirvu merged commit 9cea935 into eclipse-openj9:master Oct 28, 2019
JIT as a Service automation moved this from In progress to Done Oct 28, 2019
@harryyu1994 harryyu1994 deleted the jitserver_bug branch October 28, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants