Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed API within DAA for which Java implementations do not ex… #7726

Merged
merged 1 commit into from Nov 8, 2019

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented Nov 8, 2019

  • Removed reference to TR::com_ibm_dataaccess_ByteArrayUtils_trailingZeros
  • Removed reference to TR::com_ibm_dataaccess_ByteArrayUtils_trailingZerosByteAtATime
  • Removed reference to TR::com_ibm_dataaccess_ByteArrayUtils_trailingZerosQuadWordAtATime_

Closes: #7318

Signed-off-by: Shubham Verma shubhamv.sv@gmail.com

- Removed TR::com_ibm_dataaccess_ByteArrayUtils_trailingZeros
- Removed TR::com_ibm_dataaccess_ByteArrayUtils_trailingZerosByteAtATime
- Removed TR::com_ibm_dataaccess_ByteArrayUtils_trailingZerosQuadWordAtATime_

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@fjeremic
Copy link
Contributor

fjeremic commented Nov 8, 2019

@VermaSh see build failures. Looks like there is a few references left.

@fjeremic fjeremic self-assigned this Nov 8, 2019
@VermaSh
Copy link
Contributor Author

VermaSh commented Nov 8, 2019

@fjeremic Those failures look to be coming from OMR repo, the openj9-omr repo. Not sure if there is a way to manually propagate changes over to openj9-omr. But those references were removed in PR: eclipse/omr#4544

@fjeremic
Copy link
Contributor

fjeremic commented Nov 8, 2019

I see. So this is a dependent change. This guy should do it:

Jenkins compile all jdk8 depends eclipse/omr#4544

@fjeremic fjeremic changed the title Removed API within DAA for which Java implementations do not exist Removed API within DAA for which Java implementations do not ex… Nov 8, 2019
@fjeremic fjeremic merged commit c7b65ca into eclipse-openj9:master Nov 8, 2019
@VermaSh VermaSh deleted the DaaApiCleanup branch November 11, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate trailingZerosQuadWordAtATime
2 participants