Override needRelocationsForLookupEvaluationData #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit overrides the needRelocationsForLookupEvaluationData query found in the OMR codegenerator. The query is used to decide if a reloction record is needed when generating code for the lookup IL in power's code generator (it is needed for AOT and Remote compiles). Since OMR is not aware of remote compilations, overriding the query here will allow Openj9 to make a decision on whether a relocation record is needed. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
|
See eclipse/omr#4441 for the PR that introduces this query in OMR. |
|
@ymanton Can I get a review please? |
This was referenced Nov 20, 2019
ymanton
approved these changes
Nov 21, 2019
|
Jenkins test sanity all jdk8,jdk11 |
|
travis build failed with: Looks like an infrastructure issue. |
|
The Mac build also failed during cloning: @mpirvu Can we try launching these tests again? |
|
Jenkins test sanity osx jdk8 |
|
All builds except for travis passed. The travis failure is the one in: #7793 (comment) @ymanton @mpirvu Is it possible to try the travis build again? Or can we merge without it, considering all the other builds that have passed? |
|
Travis failed due to infra. Sanity tests passed, hence merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overrides the needRelocationsForLookupEvaluationData query found in the OMR codegenerator. The query is used to decide if a reloction record is needed when generating code for the lookup IL in power's code generator (it is needed for AOT and Remote compiles). Since OMR is not aware of remote compilations, overriding the query here will allow Openj9 to make a decision on whether a relocation record is needed.
Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com