Add structral comparison barriers #7942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
force-pushed
the
vt
branch
2 times, most recently
from
bc3822c
to
e83b6c7
Compare
|
I'd avoid using Flattened in the name. Ideally, it should work even if objects are not flattened. |
If it is not flattened we need to do a different more complicated type of comparison similar to comparing if two tree top nodes are the same. We have a separate implementation for this in the interpreter that makes use of the existing barrier APIs and a some of the VM fieldIterator APIs. The flattened case is special because we currently have no barrier APIs that perform the equivalent of memcmp. In short, we would only use this API if the object was flattened. |
|
That being said, I have no objection to changing the name |
tajila
force-pushed
the
vt
branch
8 times, most recently
from
af696b3
to
7385b19
Compare
amicic
reviewed
Dec 4, 2019
amicic
reviewed
Dec 4, 2019
|
Looks good to me. |
tajila
force-pushed
the
vt
branch
2 times, most recently
from
a008e0e
to
22a8f3a
Compare
|
@amicic The required changes have been made |
amicic
approved these changes
Dec 5, 2019
tajila
changed the title
|
Jenkins test sanity all jdk11 |
|
@amicic THe failures are all git checkout failures |
|
@tajila Would you please resolve merging conflicts? |
tajila
force-pushed
the
vt
branch
2 times, most recently
from
b798ee8
to
e752eb4
Compare
In eclipse-openj9#7743 a flag (J9ClassCanSupportFastSubstitutability) is added to each valueType class if it does not contain any floating point primitives or references that might potentially contain an unflattened valuetype or a flattened valuetype that does not contain J9ClassCanSupportFastSubstitutability. For these classes a structural comparison can be performed. This is essentially performing a memory comparison over the length of the instances, if they are equivalent the result is true, otherwise false. Since it will only contain scalar primitives and (non value) references, equality can be determined by simply performing a memory comparison. Unlike with floating point types or non-flattened valuetypes where determining equality is more complicated. A barrier helper is required as these instances may contain references. In modes where no read barriers are required memcmp can be used. Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
|
Jenkins test sanity all jdk11 |
|
@dmitripivkine @amicic The only failure is a jenkins failure |
|
The "Jenkins failure" means that no testing ran, only the compiles. It should be fixed now, retrying. Jenkins test sanity all jdk11 |
|
I forgot, I think the commit needs to be rebased in order to fix the PR testing. |
|
Another PR worked without being rebased. I had attempted to stop the earlier build, so I'll run it again. Jenkins test sanity all jdk11 |
|
@amicic @dmitripivkine All checks have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add structral comparison barriers
In #7743 a flag (
J9ClassCanSupportFastSubstitutability) is added to each valueType class if it does not contain any floating point primitives or references that might potentially contain an unflattened valuetype or a flattened valuetype that does not containJ9ClassCanSupportFastSubstitutability.For these classes a structural comparison can be performed. This is essentially performing a memory comparison over the length of the instances, if they are equivalent the result is true, otherwise false. Since it will only contain scalar primitives and (non value) references, equality can be determined by simply performing a memory comparison. Unlike with floating point types or non-flattened valuetypes where determining equality is more complicated.
A barrier helper is required as these instances may contain references. In modes where no read barriers are required
memcmpcan be used.Signed-off-by: Tobi Ajila atobia@ca.ibm.com