Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for JEP 383 (Java 15): Part 1 #9697

Merged
merged 1 commit into from May 27, 2020
Merged

Support for JEP 383 (Java 15): Part 1 #9697

merged 1 commit into from May 27, 2020

Conversation

babsingh
Copy link
Contributor

  1. Includes stubs for the following new methods:
    • class BoundMethodHandle: fieldCount and arg
    • class Lookup: defineHiddenClassWithClassData
    • class MethodHandles: permuteArgumentChecks
    • class VarHandle: target, asDirect, getMethodHandle and isDirect
  2. Includes a stub implementation for class DirectMethodHandle.
  3. The following VarHandle methods are no longer final:
    • varType, coordinateTypes and toMethodHandle

Fixes: #9684
Related: #9625

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

@babsingh
Support for JEP 383 (Java 15)
39ed99f 
1. Includes stubs for the following new methods:
    - class BoundMethodHandle: fieldCount and arg
    - class Lookup: defineHiddenClassWithClassData
    - class MethodHandles: permuteArgumentChecks
    - class VarHandle: target, asDirect, getMethodHandle and isDirect
2. Includes a stub implementation for class DirectMethodHandle.
3. The following VarHandle methods are no longer final:
    - varType, coordinateTypes and toMethodHandle

Fixes: eclipse-openj9#9684
Related: eclipse-openj9#9625

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh changed the title Support for JEP 383 (Java 15) Support for JEP 383 (Java 15): Part 1 May 26, 2020
@babsingh babsingh mentioned this pull request May 26, 2020
Closed
@pshipton
Copy link
Member

jenkins test sanity aix,xlinux,xlinuxxl,xlinuxcm,plinux,zlinux,win,osx jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

DanHeidinga
DanHeidinga approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the compile stubs

@DanHeidinga DanHeidinga added this to the Release 0.22 (Java 15) milestone May 26, 2020
@DanHeidinga DanHeidinga self-assigned this May 26, 2020
@pshipton
Copy link
Member

pshipton commented May 26, 2020 •
edited

@DanHeidinga if you are going to merge this, then you also need to push https://github.com/ibmruntimes/openj9-openjdk-jdk 92ddd31f1d3 to the openj9 branch. Ideally before anybody merges another PR in this repo, since then it can't be a simple push any more.

@DanHeidinga
Copy link
Member

Updated the openj9 branch:

$ git push origin openj9
Total 0 (delta 0), reused 0 (delta 0)
To https://github.com/ibmruntimes/openj9-openjdk-jdk.git
   5b6c38838c..92ddd31f1d  openj9 -> openj9

@DanHeidinga DanHeidinga merged commit 673559a into eclipse-openj9:master May 27, 2020
@babsingh babsingh mentioned this pull request Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanHeidinga DanHeidinga DanHeidinga approved these changes

@pshipton pshipton pshipton approved these changes

Assignees

@DanHeidinga DanHeidinga

Labels
comp:vm
Projects
None yet
Milestone
Release 0.22 (Java 15)
Development

Successfully merging this pull request may close these issues.

jdk15 compilation failures
3 participants
@babsingh @pshipton @DanHeidinga