Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature validation fails in mirror mode #938

Closed
hoangphamEclipse opened this issue Jun 7, 2024 · 1 comment · Fixed by #939
Closed

Signature validation fails in mirror mode #938

hoangphamEclipse opened this issue Jun 7, 2024 · 1 comment · Fixed by #939
Assignees
@amvanbaren
Labels
bug Something isn't working server Component: server

Comments

@hoangphamEclipse
Copy link
Contributor

Due to PR #928, the validation of signatures fail when running the OpenVSX in mirror mode since the server still expect the old signature format.

How to reproduce

  • Start the server in mirror mode, setting upstream pointing to open-vsx.org
  • Signature verification should fail at

openvsx/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java

Line 180 in 32252d3

var verified = integrityService.verifyExtensionVersion(extensionFile, signatureFile, publicKeyFile);

@amvanbaren amvanbaren self-assigned this Jun 10, 2024
@amvanbaren amvanbaren added bug Something isn't working server Component: server labels Jun 10, 2024
@hoangphamEclipse hoangphamEclipse mentioned this issue Jun 10, 2024
Merged
@hoangphamEclipse
Copy link
Contributor Author

@amvanbaren I have pushed a fix to this issue in #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amvanbaren amvanbaren

Labels
bug Something isn't working server Component: server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update signature validation logic hoangphamEclipse/openvsx
2 participants
@amvanbaren @hoangphamEclipse