No longer builds with Java 8

[dwalluck]

The commit c5fce60 added the release flag which causes the build to fail on Java 8 which does not have this flag.

You either have to use Maven profiles or simply replace

<release>${java.release}</release>

with

<source>${java.source}</source>
<target>${java.source}</target>

I also see there is a ${java.source} defined but not use. I think only one of this or ${java.release} values is needed.

[ctron]

Yes, it no longer builds on Java 8. However it still should run on Java 8. The reason for using the "release" flag was that it will check the use of APIs as well. Eliminating the need for something like the "animal sniffer" (https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/) plugin.

[dwalluck]

Can we provide a build profile, then, to build on 1.8 and have 1.9+ use the release option?

I'm currently using 1.8 so I'd like to not see that ability disappear.

[ctron]

Ok, understood. Would it be ok for you to have the 9+ be the default, and the 8 an optional profile?

[ctron]

@dwalluck I made a change on master, re-adding Java 8 compilation support. Can you check if that works for you. It looked good on travis.

[dwalluck]

@ctron I guess you forgot to push it as I don't see any recent commits, but before you do, you may want to take a look at my attempt #10.

[ctron]

Sorry. I did the change on the RPM plugin 😁 … merged your PR for the packager.

[ctron]

With the release of 0.16.1, we should be able to close this.

[dwalluck]

Verified working.