Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - Automatically simplify some plan nodes #3217

Closed
hmottestad opened this issue Jul 21, 2021 · 0 comments
Closed

SHACL - Automatically simplify some plan nodes #3217

hmottestad opened this issue Jul 21, 2021 · 0 comments
Assignees
@hmottestad
Labels
🐞 bug issue is a bug ⏩ performance 📦 SHACL affects the SHACL validator
Projects
Project Progress
Milestone
3.7.2

Comments

@hmottestad
Copy link
Contributor

Plan nodes like Union and Unique should provide a getInstance method so they can return the provided node if it makes sense.

An example is if Union is called with only one node, in this case it should return the node instead of wrapping it in a union.
@hmottestad hmottestad added ⏩ performance 📦 SHACL affects the SHACL validator labels Jul 21, 2021
@hmottestad hmottestad added this to the 3.7.2 milestone Jul 21, 2021
@hmottestad hmottestad self-assigned this Jul 21, 2021
@github-actions github-actions bot added this to 📥 Inbox in Project Progress Jul 21, 2021
@abrokenjester abrokenjester added the 📶 enhancement issue is a new feature or improvement label Jul 23, 2021
@abrokenjester abrokenjester modified the milestones: 3.7.2, 4.0.0 Jul 23, 2021
@abrokenjester abrokenjester moved this from 📥 Inbox to 📋 Backlog in Project Progress Jul 23, 2021
@hmottestad hmottestad removed the 📶 enhancement issue is a new feature or improvement label Jul 24, 2021
@hmottestad hmottestad modified the milestones: 4.0.0, 3.7.2 Jul 24, 2021
hmottestad added a commit to HASMAC-AS/rdf4j that referenced this issue Jul 26, 2021
@hmottestad
eclipse-rdf4jGH-3217 Union and Unique plan nodes can return the provi…
0af3da6 
…ded node if there is nothing they need to do; eclipse-rdf4jGH-3218 optimize QualifiedMinCount to better handle bulk validation

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to HASMAC-AS/rdf4j that referenced this issue Jul 26, 2021
@hmottestad
eclipse-rdf4jGH-3217 Union and Unique plan nodes can return the provi…
41fdf65 
…ded node if there is nothing they need to do; eclipse-rdf4jGH-3218 optimize QualifiedMinCount to better handle bulk validation

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Jul 26, 2021
Merged
5 tasks
hmottestad added a commit that referenced this issue Jul 27, 2021
@hmottestad
Merge pull request #3236 from HASMAC-AS/GH-3217-union-unique-simplify…
65071eb 
…-based-on-input

GH-3217 Union and Unique plan nodes can return the provided node if they are redundant
@hmottestad hmottestad added the 🐞 bug issue is a bug label Jul 31, 2021
Project Progress automation moved this from 📋 Backlog to 🥳 Done Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
🐞 bug issue is a bug ⏩ performance 📦 SHACL affects the SHACL validator
Projects
No open projects
Project Progress
🥳 Done
Milestone
3.7.2
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad