Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDFJson parser checks for null instead of not null in the parse method for reader #773

Closed
nikolavp opened this issue Feb 24, 2017 · 1 comment
Closed

RDFJson parser checks for null instead of not null in the parse method for reader #773

nikolavp opened this issue Feb 24, 2017 · 1 comment
Labels
🐞 bug issue is a bug
Milestone
2.2.1

Comments

@nikolavp
Copy link
Contributor

Look at line https://github.com/eclipse/rdf4j/blob/master/core/rio/rdfjson/src/main/java/org/eclipse/rdf4j/rio/rdfjson/RDFJSONParser.java#L157
@abrokenjester abrokenjester added the 🐞 bug issue is a bug label Feb 24, 2017
@barthanssens barthanssens mentioned this issue Mar 10, 2017
Merged
heshanjse added a commit to heshanjse/rdf4j that referenced this issue Mar 15, 2017
@heshanjse
eclipse-rdf4j#773 fixed by adding InputStreamReader to rdfjsonParser
755c42c
@abrokenjester
Copy link
Contributor

It looks as if three different people have now independently implemented a fix for this. Only barthanssens has actually put up a Pull Request though.

@abrokenjester abrokenjester added this to the 2.2.1 milestone Mar 18, 2017
heshanjse pushed a commit to heshanjse/rdf4j that referenced this issue Mar 19, 2017
eclipse-rdf4j#773 fixed by checking not null insted of null
2d2ed3a 
Signed-off-by: Heshan Jayasinghe <heshan.jayasinghe@gmail.com>
heshanjse added a commit to heshanjse/rdf4j that referenced this issue Mar 19, 2017
@heshanjse
eclipse-rdf4j#773 fixed by checking not null insted of null
9188db8 
Signed-off-by: Heshan Jayasinghe <shanujse@gmail.com>
catch-point pushed a commit to catch-point/rdf4j that referenced this issue Apr 20, 2017
Merge pull request eclipse-rdf4j#779 from Fedict/issues/eclipse-rdf4j…
28a4d87 
…#773-rdfjson-null

Fix eclipse-rdf4j#773: Check for handler not null instead of null
hmottestad pushed a commit that referenced this issue Apr 21, 2017
@hmottestad
Merge pull request #779 from Fedict/issues/#773-rdfjson-null
573e3ba 
Fix #773: Check for handler not null instead of null
@ansell ansell mentioned this issue Jun 1, 2017
Closed
heshanjse pushed a commit to heshanjse/rdf4j that referenced this issue Aug 27, 2017
Merge pull request eclipse-rdf4j#779 from Fedict/issues/eclipse-rdf4j…
db626b8 
…#773-rdfjson-null

Fix eclipse-rdf4j#773: Check for handler not null instead of null
Signed-off-by: Heshan Jayasinghe <shanujse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug issue is a bug
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@nikolavp @abrokenjester