Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1600 m2e lifecycle plugin hack no longer necessary for eclipse m2e #1612

Merged
merged 2 commits into from Oct 15, 2019
Merged

GH-1600 m2e lifecycle plugin hack no longer necessary for eclipse m2e #1612

merged 2 commits into from Oct 15, 2019

Conversation

abrokenjester
Copy link
Contributor

@abrokenjester abrokenjester commented Oct 15, 2019 •
edited

GitHub issue addressed: #1600

Briefly describe the changes proposed in this PR:

  • pom entry for m2e-lifecycle-plugin (which is not an actual plugin but just a dummy entry for Eclipse m2e) is no longer necessary in more recent Eclipse.
  • tested with Eclipse 2019-09
  • removes annoying warning when using commandline maven.
  • doesn't fully resolve the issue as that is also about warnings related to glassfish dependencies

@abrokenjester
Copy link
Contributor Author

Looks like I reformatted the pom.xml to use spaces instead of tabs. Not sure what happened there, will try to fix.

barthanssens
barthanssens approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@barthanssens barthanssens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds on my system with mvn clean install -Passembly

@abrokenjester
Copy link
Contributor Author

Experimentally using squash and merge. Not yet advising that everyone follows suit.

@abrokenjester abrokenjester merged commit 4b03f07 into master Oct 15, 2019
@abrokenjester abrokenjester deleted the issues/1600-m2-lifecycle-plugin branch October 15, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barthanssens barthanssens barthanssens approved these changes

@aschwarte10 aschwarte10 Awaiting requested review from aschwarte10

@hmottestad hmottestad Awaiting requested review from hmottestad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abrokenjester @barthanssens