WIP: Migrate javax -> jakarta (Jakarta EE 9) #4367
Conversation
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
from
3c7b3dc
to
9044863
Compare
| @@ -11,7 +11,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| jdk: [11, 19] | |||
| jdk: [17, 19] | |||
There was a problem hiding this comment.
I don't think that's a migration we can do at this point - there's significant subset of our users that require support for Java 11.
There was a problem hiding this comment.
I see and can understand why. 😃 Could it be an option to require Java 17 to use the modules with spring/spring-boot dependencies - if I can find a way to configure it?
There was a problem hiding this comment.
With RDF4j V5 we can all go to java 17 IMHO. Maybe it is better I open that in a discussion topic though.
There was a problem hiding this comment.
With RDF4j V5 we can all go to java 17 IMHO. Maybe it is better I open that in a discussion topic though.
I hope so. I can start a discussion about this. It is a requirement for the javax -> jakarta migration that blocks a lot of other upgrades like servlet containers (Jetty, Tomcat), Spring/Spring Boot+++
There was a problem hiding this comment.
why would you need to bump this to Java 17? RDF4J compiled for Java 11 can still be used with Java 17, no?
There was a problem hiding this comment.
Spring Boot 3.x and Spring 6.x requires Java 17. And without upgrading Spring we cannot migrate from javax to jakarta. This is WIP. We need to find a smart way of doing this....
There was a problem hiding this comment.
Sorry, I had a misunderstanding: I was thinking that some (external) Spring app using Java 17 would not require RDF4J also being compiled for Java 17. But you are actually talking about the RDF4J workbench using Spring inside, so RDF4J depending on Spring, not the other way round, right?
So maybe we create a separate module that is using a Spring6/Spring Boot 3/Java 17 variant of the workbench?
There was a problem hiding this comment.
The problem is the dependencies. You must choose, either javax or jakarta. Never both.
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
from
9044863
to
2ae0c02
Compare
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
3 times, most recently
from
e3c6b6b
to
d603a95
Compare
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
from
d603a95
to
86b7867
Compare
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
from
86b7867
to
0faba97
Compare
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
2 times, most recently
from
2179dc5
to
e88fdff
Compare
erikgb
force-pushed
the
GH-3559-javax-to-jakarta
branch
from
e88fdff
to
bf6d4ac
Compare
GitHub issue resolved: #
Briefly describe the changes proposed in this PR:
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)