GH-1755 Revert #4580
GH-1755 Revert #4580
Conversation
hmottestad
force-pushed
the
GH-1755-revert
branch
from
5c308d3
to
efdb3f1
Compare
| return reference; | ||
| } | ||
| } | ||
| ///******************************************************************************* |
There was a problem hiding this comment.
Maybe delete this file instead?
There was a problem hiding this comment.
Makes it much easier to revert my revert when I can simply uncomment the file.
| } | ||
|
|
||
| } | ||
| ///******************************************************************************* |
There was a problem hiding this comment.
Maybe delete this file instead?
| @@ -83,4 +83,11 @@ public class BinaryRDFWriterSettings { | |||
| private BinaryRDFWriterSettings() { | |||
| } | |||
|
|
|||
| static { | |||
There was a problem hiding this comment.
Isn't it better to have a test for this? I am not a big fan of Java asserts....
| @@ -35,9 +35,9 @@ | |||
| import org.eclipse.rdf4j.rio.RDFParser; | |||
| import org.eclipse.rdf4j.rio.helpers.AbstractRDFHandler; | |||
| import org.eclipse.rdf4j.rio.helpers.BasicParserSettings; | |||
| import org.eclipse.rdf4j.rio.helpers.NTriplesParserSettings; | |||
There was a problem hiding this comment.
Is this intentional? I thought we were just reverting the JSON-LD changes.
There was a problem hiding this comment.
Yeah. All the tests are reverted so that I could be sure that there wasn't anything I had missed.
There was a problem hiding this comment.
Oh, that makes sense, thanks!
| import org.eclipse.rdf4j.rio.helpers.SimpleParseLocationListener; | ||
| import org.eclipse.rdf4j.rio.helpers.StatementCollector; | ||
| import org.eclipse.rdf4j.rio.ntriples.NTriplesParserSettings; |
There was a problem hiding this comment.
Is this intentional? I thought we were just reverting the JSON-LD changes.
| @@ -81,9 +81,6 @@ public Stream<ShapesGraph> getAllShapeContexts() { | |||
|
|
|||
| List<? extends Statement> collect = stream.collect(Collectors.toList()); | |||
|
|
|||
| if (collect.size() > 0) { | |||
There was a problem hiding this comment.
Does this belong is this PR? I prefer self-contained PRs.
There was a problem hiding this comment.
It should be in it's own PR.
GitHub issue resolved: #4586
Briefly describe the changes proposed in this PR:
Revert changes from GH-1755
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)