Paper UI: Fix binding details view (#6364)

Fixes #6356. Signed-off-by: Henning Treu <henning.treu@telekom.de>
eclipse-archived · Oct 15, 2018 · bf9667a · bf9667a
1 parent 2f03235
commit bf9667a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/...nsions/ui/org.eclipse.smarthome.ui.paper/web-src/js/bindings/directive.binding-details.js b/...nsions/ui/org.eclipse.smarthome.ui.paper/web-src/js/bindings/directive.binding-details.js
@@ -17,12 +17,13 @@
         this.configure = configure;
         this.navigateTo = navigateTo;
 
-        activate();
+        this.$onInit = activate;
 
         function activate() {
             titleService.setTitle('Configuration');
 
             var bindingId = $routeParams.bindingId;
+
             bindingRepository.getOne(function(binding) {
                 return binding.id === bindingId;
             }, function(binding) {

diff --git a/...ons/ui/org.eclipse.smarthome.ui.paper/web-src/js/bindings/directive.binding-thingtypes.js b/...ons/ui/org.eclipse.smarthome.ui.paper/web-src/js/bindings/directive.binding-thingtypes.js
@@ -2,7 +2,7 @@
 (function() {
     'use strict';
 
-    angular.module('PaperUI.bindings').directive('bindingThingtypes', {
+    angular.module('PaperUI.bindings').component('bindingThingtypes', {
         bindings : {
             binding : '='
         },
@@ -12,7 +12,6 @@
 
     function BindingThingtypesController() {
         var ctrl = this;
-        this.binding;
         this.filter = {
             text : ''
         };

diff --git a/extensions/ui/org.eclipse.smarthome.ui.paper/web-src/js/repositories/repositories-module.js b/extensions/ui/org.eclipse.smarthome.ui.paper/web-src/js/repositories/repositories-module.js
@@ -79,15 +79,10 @@
                 getAll(null, true).then(function(res) {
                     if (callback) {
                         resolveSingleElement(callback, find(condition));
-                        return;
-                    } else {
-                        return;
                     }
                 }, function(res) {
                     callback(null);
-                    return;
                 }, function(res) {
-                    return;
                 });
             }
         }