DBus Transport Bundle

[cdjackson]

This is provided for visibility as it will require CQ.

The current DBus library is not complete implementation of the DBus protocol. It doesn't support part of the authentication handshake required to pass unix file descriptors, and then doesn't support the file descriptors when passed as args.

Currently, this is required for audio profiles, and under current BlueZ it is not possible to use TCP for this! While some changes might be looked at to provide support for TCP as well, it still seems sensible to support Unix FDs as this is a more 'out of the box' configuration.

This PR contains a number of commits to provide traceability. I started with the original file we go from Eclipse Foundation, formatted it, and then modified it. I'm happy to squash, but wanted to provide that traceability to the original file.

I'd also be surprised if this doesn't require further updates, so it's provided for visibility, discussion, and CQ kickoff (if such a thing exists)

Signed-off-by: Chris Jackson chris@cd-jackson.com

[maggu2810]

What is the academic free license? I assume we have to choose this one instead of LGPL (or at least the IP team).
I am happy to keep the commits separated but there seems something going wrong with the formatter commit (or I am missing something).
I looked at the last commit (add license and update manifest) and it contains a lot of reformat.

Without checkout and looking into it myself, what is the unix 0.5 library about?

[cdjackson]

Kai should look at this since we already have discussed this a lot and most of the license issues are already sorted or under CQ. Some of the conversation is in the other Bluetooth PR but some was private emails so probably best for Kai to look over this.

[kaikreuzer]

the included filename is 0.5 - which version is right?

[kaikreuzer]

@maggu2810 FTR, the CQ for lib-dbus is 10561.

@cdjackson Regarding a CQ for unix, you never answered my question here and hence I didn't yet create any CQ for it. If http://javadoc.matthew.ath.cx/projects/java/libmatthew-java-0.8.tar.gz is the right location, I can go ahead and create a CQ with these sources.
Btw, I have just found that there are already approved CQs for https://github.com/jnr/jnr-unixsocket - but I guess this library is not usable for us, right?

[cdjackson]

Sorry - I just copied the readme over from the other repository for dbus - I'll update it.

Sorry (again) I missed your comment about the unix lib version. Well, the version I have is 0.5 - this is typically installed (or installable) directly with apt-get in unix (apt-get install libunixsocket-java) and I think if you do this, you get version 0.5.

My concern with changing to 0.8 is that if anything 'significant' has changed, then we might have an issue with distribution since we'd need to recompile the native side as well (if that interface changed). We could of course leave it out and let it be installed by the user, but that's likely to be a nightmare for installation.

Anyway, forgetting the above for a second - If it makes life easier, I could probably use this library. The DBus library probably only uses these calls in one file, so changing it would likely be easy and it's one of the files I've already changed to add support for the additional authentication handshake required.

[kaikreuzer]

Well, the version I have is 0.5

But this seems to imply that http://javadoc.matthew.ath.cx/projects/java/libmatthew-java-0.8.tar.gz is not the corresponding source code and hence I cannot use this for creating the CQ...

[cdjackson]

Yes - that would be correct… I’ve not managed to find a definitive source for this - there are a number that I found, but none that we could say are the original authors...

[kaikreuzer]

Shall we try to reach out to Matthew? It seems that the IP team was at least once in contact with him already.

[kaikreuzer]

FTR, I created a CQ for libmatthew-java, see #551 (comment).

[kaikreuzer]

As mentioned on #551 the CQ is approved.
@cdjackson Could you update this PR accordingly?

[kaikreuzer]

@cdjackson Did you see my last comment?

[cdjackson]

Sorry - I did see this but haven't yet looked at it. I'll look to update this over the coming few days.

[kaikreuzer]

@cdjackson Ping :-)

[OnirbanBose]

Hi any updates to the DBus libraries? I tried testing it on a RPi3 (after updating to Bluez 5.41), but didn't seem to work. Trying to debug.

Reg's
Anirban

[cdjackson]

The DBus libraries won’t change function - the current issue is simply to move them from the source to attached JAR, so I doubt it will change your problem.

[cdjackson]

Source removed + JAR added.

[kaikreuzer]

looks as if you are missing the second jar here?

[kaikreuzer]

Please update build.properties - besides this, the PR now lgtm.

[cdjackson]

Updated.

On 18 Sep 2016, at 10:52, Kai Kreuzer notifications@github.com wrote:

@kaikreuzer requested changes on this pull request.

Please update build.properties - besides this, the PR now lgtm.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1234 (review), or mute the thread https://github.com/notifications/unsubscribe-auth/AA_kQ_hbSuMnJmdDrnLmu6woYy03BYXqks5qrQnGgaJpZM4H0j4H.

[kaikreuzer]

Thanks! So next up is the BLE binding :-)