This repository has been archived by the owner on May 7, 2020. It is now read-only.
Avoid NPE if empty sitemap file is loaded #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
sjsf
reviewed
Jul 12, 2017
| @@ -215,7 +216,7 @@ private void addCallbackToListener(String sitemapName, String pageId, SitemapSub | |||
| } | |||
|
|
|||
| private EList<Widget> collectWidgets(String sitemapName, String pageId) { | |||
| EList<Widget> widgets = null; | |||
| EList<Widget> widgets = new BasicEList<Widget>(); | |||
There was a problem hiding this comment.
fully makes sense!
Could you please also adapt (i.e. simplify) lines 206-215, not that we know it's never gonna be null?
There was a problem hiding this comment.
The variable in line 205 is just a local one and there is a check for null before the function does something with this null list .
EDIT: nevermind: you had a typo "not" instead of "now" which confused me :) I changed the code to be aware of that collectWidgets always returns an (empty) list.
There was a problem hiding this comment.
argh, sorry for the confusion!
Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3820
Signed-off-by: Stefan Triller stefan.triller@telekom.de